Repository navigation
misc: fix spelling - #8272
misc: fix spelling#8272jbampton wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8272 +/- ##
============================================
- Coverage 20.78% 20.78% -0.01%
Complexity 20858 20858
============================================
Files 6053 6053
Lines 548230 548230
Branches 73237 78410 +5173
============================================
- Hits 113927 113926 -1
- Misses 420955 420956 +1
Partials 13348 13348
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
a3a71eb to
c67db42
Compare
c67db42 to
85bbec8
Compare
|
@blueorangutan package |
|
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7843 |
|
@blueorangutan test |
|
@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
DaanHoogland
left a comment
There was a problem hiding this comment.
I see nothing only good language corrections here but I have two issues with the change as a whole:
- I see some corrections in commented and possibly dead code. Those should be handled by removing them
- I see some variable on interfaces of the system, that might give unexpected results either during or after upgrades. I'd like to see those extracted to separate commits, to facilitate testing and trouble shooting.
|
[SF] Trillian test result (tid-8405)
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@jbampton I merged the current |
|
Thanks @andrijapanicsb for clearing the conflicts 👍 |
|
since code has changed at least a new run of smoke tests are in order. |
|
@blueorangutan package |
|
@jbampton , is this ready for what you are concerned? |
andrijapanicsb
left a comment
There was a problem hiding this comment.
LGTM
Not sure why I'm reviewing my own work; that never ends up well...
But, for reference, conflicts are solved as in the attached file.
|
You have to shout to tell him |
|
@andrijapanicsb a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 20075 |
|
Thanks everyone for addressing this issue / PR and for fixing the conflicts. I can see it was mid August when I wrote my "remark" my own fault sorry for that I had recently broken my back. Not much has happened here since. |
Description
This PR fixes spelling
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?