KVM: skip mountpoint check for RBD storage pools #11690
Open
+21
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…snapshot errors)"
shwstppr
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11690 +/- ##
============================================
+ Coverage 17.36% 17.39% +0.03%
- Complexity 15234 15283 +49
============================================
Files 5886 5889 +3
Lines 525680 526194 +514
Branches 64159 64243 +84
============================================
+ Hits 91261 91544 +283
- Misses 424120 424304 +184
- Partials 10299 10346 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using Ceph RBD as primary storage on KVM, the agent currently tries to run:
mountpoint -q /mnt/
This fails because RBD pools are not mounted like NFS or other network filesystems.
As a result, snapshot and template operations fail with errors such as:
libvirt failed to mount storage pool at /mnt/
This patch updates LibvirtStorageAdaptor to skip the mountpoint check when the storage pool type is RBD.
It prevents false errors while keeping the logic unchanged for NFS/NetFS pools.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Bug Severity
Major (affects snapshot/template functionality on Ceph RBD)
How Has This Been Tested?
CloudStack 4.21.0.0 + Ceph RBD backend (client.cloudstack user)
Created multiple VM snapshots → successfully registered in Ceph
Created templates from snapshots → completed without mountpoint errors
Verified no regressions on other pool types (NFS untouched)
Checked agent.log: no further mountpoint failures for RBD pools
Related issues
N/A (first-time fix)