KVM: fix delete vm snapshot if it does not exist with a Stopped vm #11687

weizhouapache · 2025-09-19T13:04:57Z

Description

This PR fixes #11673

Steps to reproduce the issue

deploy vm in kvm environments
create vm snapshot
delete the vm snapshot by `qemu-img snapshot -d
stop the vm
delete the vm snapshot on cloudstack GUI

Prior to this PR

2025-09-19T12:14:05,455 DEBUG [utils.script.Script] (Script-7:[]) (logid:) Piped commands executed successfully
2025-09-19T12:14:05,455 DEBUG [utils.script.Script] (AgentRequest-Handler-2:[]) (logid:) Executing command [/usr/bin/qemu-img snapshot -d i-2-23-VM_VS_20250919102815 /mnt/92a06402-16ab-35e8-950e-d84499c5e942/57c64582-aa4b-4329-bf18-9bcb14dffd57 ].
2025-09-19T12:14:05,594 WARN  [utils.script.Script] (AgentRequest-Handler-2:[]) (logid:) Execution of process [983177] for command [/usr/bin/qemu-img snapshot -d i-2-23-VM_VS_20250919102815 /mnt/92a06402-16ab-35e8-950e-d84499c5e942/57c64582-aa4b-4329-bf18-9bcb14dffd57 ] failed.
2025-09-19T12:14:05,594 DEBUG [utils.script.Script] (AgentRequest-Handler-2:[]) (logid:) Exit value of process [983177] for command [/usr/bin/qemu-img snapshot -d i-2-23-VM_VS_20250919102815 /mnt/92a06402-16ab-35e8-950e-d84499c5e942/57c64582-aa4b-4329-bf18-9bcb14dffd57 ] is [1].
2025-09-19T12:14:05,594 WARN  [utils.script.Script] (AgentRequest-Handler-2:[]) (logid:) Process [983177] for command [/usr/bin/qemu-img snapshot -d i-2-23-VM_VS_20250919102815 /mnt/92a06402-16ab-35e8-950e-d84499c5e942/57c64582-aa4b-4329-bf18-9bcb14dffd57 ] encountered the error: [1].
2025-09-19T12:14:05,595 DEBUG [cloud.agent.Agent] (AgentRequest-Handler-2:[]) (logid:) Seq 1-8671962557478622109:  { Ans: , MgmtId: 32986372244225, via: 1, Ver: v1, Flags: 10, [{"com.cloud.agent.api.DeleteVMSnapshotAnswer":{"result":"false","details":"Delete VM Snapshot Failed due to can not remove snapshot from image file /mnt/92a06402-16ab-35e8-950e-d84499c5e942/57c64582-aa4b-4329-bf18-9bcb14dffd57 : 1","wait":"0","bypassHostMaintenance":"false"}}] }

With this PR

2025-09-19T12:59:29,526 DEBUG [utils.script.Script] (Script-9:[]) (logid:) Piped commands executed successfully
2025-09-19T12:59:29,527 DEBUG [resource.wrapper.LibvirtDeleteVMSnapshotCommandWrapper] (AgentRequest-Handler-5:[]) (logid:) qemu_img_snapshot =
2025-09-19T12:59:29,528 INFO  [resource.wrapper.LibvirtDeleteVMSnapshotCommandWrapper] (AgentRequest-Handler-5:[]) (logid:) Cannot find snapshot i-2-23-VM_VS_20250919102815 in file /mnt/92a06402-16ab-35e8-950e-d84499c5e942/57c64582-aa4b-4329-bf18-9bcb14dffd57, return true

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache · 2025-09-19T13:10:25Z

@blueorangutan package

blueorangutan · 2025-09-19T13:12:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-09-19T13:12:36Z

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (9167cd3) to head (8cfa064).
⚠️ Report is 10 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #11687      +/-   ##
============================================
- Coverage     16.17%   16.17%   -0.01%     
  Complexity    13297    13297              
============================================
  Files          5656     5656              
  Lines        498151   498151              
  Branches      60441    60441              
============================================
- Hits          80589    80587       -2     
- Misses       408589   408591       +2     
  Partials       8973     8973

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`17.03% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

...in/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java

blueorangutan · 2025-09-19T15:33:33Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15105

weizhouapache · 2025-09-19T19:44:17Z

@blueorangutan test

blueorangutan · 2025-09-19T19:46:06Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-09-20T11:28:13Z

[SF] Trillian test result (tid-14400)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53352 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11687-t14400-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache · 2025-09-22T14:55:17Z

@blueorangutan package

blueorangutan · 2025-09-22T14:56:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-22T16:27:19Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15136

weizhouapache · 2025-09-22T18:09:16Z

@blueorangutan test

blueorangutan · 2025-09-22T18:10:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-09-23T09:47:40Z

[SF] Trillian test result (tid-14417)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53319 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11687-t14417-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

abh1sar

LGTM

vishesh92

lgtm. didn't test.

rajujith

LGTM
Tested, resolves the reported issue.

weizhouapache · 2025-09-24T11:53:19Z

merging based on approvals and manual test by @rajujith

thanks all

KVM: fix delete vm snapshot if it does not exist with a Stopped vm

654f0b2

weizhouapache added this to the 4.20.2 milestone Sep 19, 2025

boring-cyborg bot added the component:kvm label Sep 19, 2025

weizhouapache linked an issue Sep 19, 2025 that may be closed by this pull request

Unable to delete Instance snapshot in "Error' state on stopped Instances #11673

Closed

DaanHoogland reviewed Sep 19, 2025

View reviewed changes

...in/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtDeleteVMSnapshotCommandWrapper.java Outdated Show resolved Hide resolved

update 11687

8cfa064

weizhouapache assigned rajujith Sep 23, 2025

weizhouapache requested review from harikrishna-patnala and vishesh92 September 23, 2025 09:50

abh1sar approved these changes Sep 24, 2025

View reviewed changes

vishesh92 approved these changes Sep 24, 2025

View reviewed changes

rajujith approved these changes Sep 24, 2025

View reviewed changes

weizhouapache merged commit 36cfd76 into apache:4.20 Sep 24, 2025
41 of 43 checks passed

weizhouapache mentioned this pull request Sep 24, 2025

Unable to delete Instance snapshot in "Error' state on stopped Instances #11673

Closed

KVM: fix delete vm snapshot if it does not exist with a Stopped vm #11687

KVM: fix delete vm snapshot if it does not exist with a Stopped vm #11687

Uh oh!

Conversation

weizhouapache commented Sep 19, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented Sep 19, 2025

Uh oh!

blueorangutan commented Sep 19, 2025

Uh oh!

codecov bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

blueorangutan commented Sep 19, 2025

Uh oh!

weizhouapache commented Sep 19, 2025

Uh oh!

blueorangutan commented Sep 19, 2025

Uh oh!

blueorangutan commented Sep 20, 2025

Uh oh!

weizhouapache commented Sep 22, 2025

Uh oh!

blueorangutan commented Sep 22, 2025

Uh oh!

blueorangutan commented Sep 22, 2025

Uh oh!

weizhouapache commented Sep 22, 2025

Uh oh!

blueorangutan commented Sep 22, 2025

Uh oh!

blueorangutan commented Sep 23, 2025

Uh oh!

abh1sar left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

rajujith left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Sep 24, 2025

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Sep 19, 2025 •

edited

Loading