-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix vpclimit count for listAcccount API response #11686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11686 +/- ##
============================================
+ Coverage 16.17% 17.39% +1.21%
- Complexity 13297 15285 +1988
============================================
Files 5656 5889 +233
Lines 498151 526183 +28032
Branches 60441 64242 +3801
============================================
+ Hits 80588 91542 +10954
- Misses 408591 424297 +15706
- Partials 8972 10344 +1372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@blueorangutan package |
@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15100 |
@blueorangutan test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
verifed OK+ |
Description
This PR fixes #11683
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Configured limit is 10 on account and response shows it correctly.
How Has This Been Tested?
How did you try to break this feature and the system with this change?