Skip to content

Conversation

sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Sep 19, 2025

Description

This PR fixes #11683

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot 2025-09-19 at 12 54 27 PM

Configured limit is 10 on account and response shows it correctly.

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sudo87 sudo87 changed the base branch from main to 4.20 September 19, 2025 07:25
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.39%. Comparing base (0cbebbd) to head (7ea9416).
⚠️ Report is 9 commits behind head on 4.20.

Files with missing lines Patch % Lines
...pache/cloudstack/api/response/AccountResponse.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #11686      +/-   ##
============================================
+ Coverage     16.17%   17.39%   +1.21%     
- Complexity    13297    15285    +1988     
============================================
  Files          5656     5889     +233     
  Lines        498151   526183   +28032     
  Branches      60441    64242    +3801     
============================================
+ Hits          80588    91542   +10954     
- Misses       408591   424297   +15706     
- Partials       8972    10344    +1372     
Flag Coverage Δ
uitests 3.62% <ø> (-0.39%) ⬇️
unittests 18.44% <0.00%> (+1.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sudo87 sudo87 requested a review from DaanHoogland September 19, 2025 08:25
@sudo87
Copy link
Collaborator Author

sudo87 commented Sep 19, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15100

@weizhouapache weizhouapache added this to the 4.20.2 milestone Sep 19, 2025
@weizhouapache
Copy link
Member

@blueorangutan test

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@weizhouapache
Copy link
Member

verifed OK+

@weizhouapache weizhouapache merged commit 96992d3 into apache:4.20 Sep 24, 2025
26 of 27 checks passed
@DaanHoogland DaanHoogland deleted the vpcLimitResponse branch September 24, 2025 11:10
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

list accounts results in incorrect VPC limit being returned

5 participants