Skip to content

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes #11644

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.39%. Comparing base (8eb6ddd) to head (13c7e0c).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
.../cloud/storage/upload/params/UploadParamsBase.java 0.00% 9 Missing ⚠️
...n/java/com/cloud/template/TemplateAdapterBase.java 0.00% 9 Missing ⚠️
...n/java/com/cloud/template/TemplateManagerImpl.java 0.00% 3 Missing and 1 partial ⚠️
...d/user/template/GetUploadParamsForTemplateCmd.java 0.00% 3 Missing ⚠️
...ud/storage/upload/params/TemplateUploadParams.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11682      +/-   ##
============================================
- Coverage     17.39%   17.39%   -0.01%     
  Complexity    15285    15285              
============================================
  Files          5889     5889              
  Lines        526183   526201      +18     
  Branches      64242    64242              
============================================
- Hits          91542    91540       -2     
- Misses       424297   424315      +18     
- Partials      10344    10346       +2     
Flag Coverage Δ
uitests 3.62% <ø> (ø)
unittests 18.44% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15085

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15093

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-14386)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-14390)

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, didn't test

@blueorangutan
Copy link

[SF] Trillian test result (tid-14392)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55801 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11682-t14392-kvm-ol8.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_scale_kubernetes_cluster Failure 1.15 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 29.88 test_kubernetes_clusters.py

@DaanHoogland
Copy link
Contributor

@blueorangutan test keepEnv

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-14413)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 58324 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11682-t14413-kvm-ol8.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_scale_kubernetes_cluster Failure 1.16 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 42.16 test_kubernetes_clusters.py

@DaanHoogland
Copy link
Contributor

verified in lab env
Screenshot 2025-09-22 at 10 46 03

@DaanHoogland DaanHoogland merged commit 69998f7 into apache:main Sep 22, 2025
27 of 28 checks passed
@DaanHoogland DaanHoogland deleted the 4.22-upload-template-with-type branch September 22, 2025 08:46
@weizhouapache
Copy link
Member Author

verified in lab env Screenshot 2025-09-22 at 10 46 03

thanks for the testing @DaanHoogland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Uploading VNF Template from local always registers a USER template
4 participants