Keeping consistency with other error messages. #11649
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #11649 +/- ##
=============================================
- Coverage 17.37% 3.62% -13.76%
=============================================
Files 5885 441 -5444
Lines 524852 37135 -487717
Branches 64030 6808 -57222
=============================================
- Hits 91196 1346 -89850
+ Misses 423367 35625 -387742
+ Partials 10289 164 -10125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15046 |
api/src/main/java/org/apache/cloudstack/api/command/user/vpn/UpdateVpnConnectionCmd.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/apache/cloudstack/api/command/user/vpn/UpdateVpnGatewayCmd.java
Outdated
Show resolved
Hide resolved
engine/schema/src/main/java/com/cloud/vm/dao/UserVmDaoImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: dahn <[email protected]>
|
|
||
| @Override | ||
| public String getEventDescription() { | ||
| return "Update load balancer health check policy ID= " + id; |
There was a problem hiding this comment.
The id attribute here represents the resource's serial ID, right? We should always try to expose the UUID instead
|
|
||
| @Override | ||
| public String getEventDescription() { | ||
| return "Update load balancer stickiness policy ID= " + id; |
There was a problem hiding this comment.
Same as #11649 (comment)
|
|
||
| @Override | ||
| public String getEventDescription() { | ||
| return "Updating site-to-site VPN connection id= " + id; |
There was a problem hiding this comment.
Same as #11649 (comment)
|
|
||
| @Override | ||
| public String getEventDescription() { | ||
| return "Update site-to-site VPN gateway id= " + id; |
There was a problem hiding this comment.
Same as #11649 (comment)
| result.add(new Ternary<Integer, Integer, Integer>(rs.getInt(1), rs.getInt(2), rs.getInt(3))); | ||
| } | ||
| } catch (Exception e) { | ||
| logger.warn("Error counting vms by size for dcId= " + dcId, e); |
There was a problem hiding this comment.
Same as #11649 (comment)
| return rs.getLong(1); | ||
| } | ||
| } catch (Exception e) { | ||
| logger.warn(String.format("Error counting vms by host tag for dcId= %s, hostTag= %s", dcId, hostTag), e); |
There was a problem hiding this comment.
Same as #11649 (comment)
| } | ||
|
|
||
| if (domainId != null && !domainId.equals(caller.getDomainId())) { | ||
| throw new PermissionDeniedException("Can't list domain id= " + domainId + " projects; unauthorized"); |
There was a problem hiding this comment.
Same as #11649 (comment)
Description
This PR makes trivial changes to the strings that are presented top the UI users.
While investigating a mysterious issue this message trough me off rails, chasing a possible heading or trailing space character.
I searched how this throws were presented in the code and realized this is probably how it should be presented.
It was easy to spot a few other occasions of the same pattern.
I am sorry if this sounds irrelevant but I hope this helps others.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?