-
Notifications
You must be signed in to change notification settings - Fork 1.2k
honor templateId passed in importVM API #11640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11640 +/- ##
=========================================
Coverage 16.17% 16.17%
Complexity 13297 13297
=========================================
Files 5656 5656
Lines 498151 498147 -4
Branches 60441 60440 -1
=========================================
Hits 80588 80588
+ Misses 408591 408586 -5
- Partials 8972 8973 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @sudo87 - LGTM. Just a minor non-blocking comment
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java
Outdated
Show resolved
Hide resolved
@blueorangutan package |
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15026 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
@blueorangutan test |
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
[SF] Trillian test result (tid-14357)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
tested ok @rajujith |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested.
🐱 > import vm name=Sept43-1 displayname=Sept24-1 importsource=shared hypervisor=kvm storageid=66db3292-7010-33a1-afe5-207ac57d9572 diskpath=Sept24-1.qcow2 networkid=9bd3611f-ea90-4c47-a66f-d332f412f5d1 serviceofferingid=40c50a8c-5436-45cd-bfd2-d829598db7a9 migrateallowed=true zoneid=848078d5-437f-46db-9859-add728d7193f clusterid=44be2e50-783a-4b52-bb02-6f3b476fb4cc templateid=52237ee7-9908-11f0-a5f2-1e001f000a0a
{
"virtualmachine": {
"account": "admin",
"affinitygroup": [],
"arch": "x86_64",
"cpunumber": 1,
"cpuspeed": 500,
"created": "2025-09-24T06:29:38+0000",
"deleteprotection": false,
"details": {
"deployvm": "true"
},
"displayname": "Sept24-1",
"displayvm": true,
"domain": "ROOT",
"domainid": "521d71c5-9908-11f0-a5f2-1e001f000a0a",
"domainpath": "/",
"guestosid": "52325051-9908-11f0-a5f2-1e001f000a0a",
"haenable": false,
"hasannotations": false,
"hypervisor": "KVM",
"id": "2ef17308-476d-40b9-8bf1-7fab2c25ef66",
"instancename": "i-2-5-VM",
"ipaddress": "10.1.1.53",
"isdynamicallyscalable": false,
"memory": 512,
"name": "Sept43-1",
"nic": [
{
"broadcasturi": "vlan://1104",
"deviceid": "0",
"extradhcpoption": [],
"gateway": "10.1.1.1",
"id": "bfc5fbd5-db2f-4c12-b0fe-52a3117042f9",
"ipaddress": "10.1.1.53",
"isdefault": true,
"isolationuri": "vlan://1104",
"macaddress": "02:01:00:cc:00:03",
"netmask": "255.255.255.0",
"networkid": "9bd3611f-ea90-4c47-a66f-d332f412f5d1",
"networkname": "mynet",
"secondaryip": [],
"traffictype": "Guest",
"type": "Isolated"
}
],
"osdisplayname": "CentOS 5.5 (64-bit)",
"ostypeid": "52325051-9908-11f0-a5f2-1e001f000a0a",
"passwordenabled": false,
"pooltype": "NetworkFilesystem",
"receivedbytes": 0,
"rootdeviceid": 1,
"rootdevicetype": "ROOT",
"securitygroup": [],
"sentbytes": 0,
"serviceofferingid": "40c50a8c-5436-45cd-bfd2-d829598db7a9",
"serviceofferingname": "Small Instance",
"state": "Stopped",
"tags": [],
"templatedisplaytext": "CentOS 5.5(64-bit) no GUI (KVM)",
"templateformat": "QCOW2",
"templateid": "52237ee7-9908-11f0-a5f2-1e001f000a0a",
"templatename": "CentOS 5.5(64-bit) no GUI (KVM)",
"templatetype": "BUILTIN",
"userid": "a100524d-9908-11f0-a5f2-1e001f000a0a",
"username": "admin",
"zoneid": "848078d5-437f-46db-9859-add728d7193f",
"zonename": "pr11640-t7138-kvm-rocky9"
}
```}
thanks @rajujith ! merging |
Description
This PR fixes #11603 and considers templateid passed in import vm api request.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?