Skip to content

Introduce volume allocation algorithm global configuration #10696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Introduce volume allocation algorithm global configuration #10696

wants to merge 12 commits into from

Conversation

sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Apr 11, 2025 •
edited by rohityadavcloud
Loading

Description

This PR introduces separate global configuration for Volume allocation algorithm.

Volume allocation has been using vm.allocation.algorithm config value. It can be confusing and limitting user to use same allocation algorithm for both VM and Volume.
This new configuration will allow vm and volume allocators to use different algoritms independently without being tied together.

Doc PR apache/cloudstack-documentation#499

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Local dev testing is done by deployment of instances against simulator after setting different values for "volume.allocation.algorithm".

How did you try to break this feature and the system with this change?

@sudo87
Introduce volume allocation algorithm global configuration.
b28db5d 
Volume allocation has been using vm.allocation.algorithm config value. This change will allow them to be configured in isolation.
@codecov Codecov
Copy link

codecov bot commented Apr 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.99%. Comparing base (6fdaf51) to head (f396fa9).

❗ There is a different number of reports uploaded between BASE (6fdaf51) and HEAD (f396fa9). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6fdaf51) HEAD (f396fa9)
unittests 1 0
Additional details and impacted files 
@@              Coverage Diff              @@
##               main   #10696       +/-   ##
=============================================
- Coverage     16.41%    3.99%   -12.42%     
=============================================
  Files          5702      401     -5301     
  Lines        503405    32654   -470751     
  Branches      60976     5791    -55185     
=============================================
- Hits          82626     1306    -81320     
+ Misses       411594    31198   -380396     
+ Partials       9185      150     -9035
Flag Coverage Δ
uitests 3.99% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rajujith rajujith self-requested a review April 11, 2025 05:32
@rajujith
Copy link

@blueorangutan package

@blueorangutan
Copy link

@rajujith a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13019

DaanHoogland
DaanHoogland approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13020

@Pearl1594 Pearl1594 added this to the 4.21.0 milestone Apr 11, 2025
@sudo87
Copy link
Collaborator Author

sudo87 commented Apr 14, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13046

@sudo87
Copy link
Collaborator Author

sudo87 commented Apr 15, 2025

@blueorangutan test

@blueorangutan
Copy link

@sudo87 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@weizhouapache
Copy link
Member

code lgtm

However, I think we need to think of the upgrade
for example, now the vm/volume allocation algorithm is set to firstfit, when uprgade to a new version with this PR, the vm allocation algorithm is still firstfit, but volume allocation algorithm will be the default value random.

@sudo87

@blueorangutan
Copy link

[SF] Trillian test result (tid-12988)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54138 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10696-t12988-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@sudo87
Copy link
Collaborator Author

sudo87 commented Apr 25, 2025

LGTM. Tested with multiple shared NFS primary storage. If the logging for the firstfitleastconsumed can print the available capacity as well in the logs it will be useful.

'List of pools in descending order of available capacity [[1, 2]].'

Thanks @rajujith for suggestion! Change is made to enhance log to show available capacity for host/pool.

Screenshot from 2025-04-25 15-50-40

@sudo87 sudo87 mentioned this pull request Apr 25, 2025
Open
harikrishna-patnala
harikrishna-patnala approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13338

borisstoyanov
borisstoyanov approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, testing has passed.

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@blueorangutan
Copy link

[SF] Trillian test result (tid-13274)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56331 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10696-t13274-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@boring-cyborg boring-cyborg bot added component:marvin Python Warning... Python code Ahead! labels May 13, 2025
@sudo87 sudo87 force-pushed the volumeAllocator branch from 58c893d to 958b066 Compare May 13, 2025 04:45
@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@sudo87 sudo87 force-pushed the volumeAllocator branch from 958b066 to f396fa9 Compare May 13, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@rajujith rajujith rajujith approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

@borisstoyanov borisstoyanov

Labels
component:agent component:api component:integration component:marvin component:orchestration component:storage Python Warning... Python code Ahead!
Projects
None yet
Milestone
4.21.0
Development

Successfully merging this pull request may close these issues.
9 participants
@sudo87 @rajujith @blueorangutan @DaanHoogland @weizhouapache @rohityadavcloud @harikrishna-patnala @borisstoyanov @Pearl1594