Fix egress firewall rules to support all-ports without explicit ports

[sidshas03]

• Allow omitting ports parameter for TCP/UDP protocols to create rules that encompass all ports
• Update validation to make ports parameter optional for TCP/UDP protocols
• Add support for reading rules created without explicit ports
• Add test case for all-ports functionality
• Update documentation with example and clarification

Fixes #202

[kiranchavala]

@sidshas03 Could you please make sure the test pass

[sidshas03]

@sidshas03 Could you please make sure the test pass

Sure sir. I'm working on it. Sorry for the late reply!

[sidshas03]

@kiranchavala I’ve pushed updates to support TCP/UDP all-ports when ports are omitted, normalize reads for 0/0, -1/-1, and 1/65535, add an acceptance test, and update the docs. I’m watching CI and will fix anything that fails as soon as the test cases start running. Thanks!

Commit: e16d5a2

[sidshas03]

Status update:
– Pushed no-op commit Commit ID 987dc7b to retrigger the full acceptance matrix.
– Local make build && make test pass.
– Failures previously looked like simulator start/timeout rather than code.
If the matrix still flakes, I can (a) bump the simulator readiness wait in our composite action, or (b) temporarily narrow acceptance to the egress firewall tests to prove the fix. Happy to push either change.

[kiranchavala]

Thanks @sidshas03 i see that tests are failing at this point

cc @vishesh92

[Copilot]

Pull Request Overview

This PR enables support for all-ports firewall rules in the CloudStack egress firewall resource by making the ports parameter optional for TCP/UDP protocols. When ports are omitted, the provider creates rules that encompass all ports, providing better flexibility for firewall configurations.

• Allow omitting ports parameter for TCP/UDP protocols to create all-ports rules
• Add comprehensive test coverage for all-ports functionality including transitions
• Update documentation with examples demonstrating all-ports usage

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
cloudstack/resource_cloudstack_egress_firewall.go	Core logic to handle all-ports rules creation and reading, with validation changes
cloudstack/resource_cloudstack_egress_firewall_test.go	Comprehensive test cases for all-ports functionality and transitions
website/docs/r/egress_firewall.html.markdown	Documentation updates with examples and clarification

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The sentence structure is unclear and contains a grammatical error. Consider revising to: 'be specified if the protocol is TCP or UDP. For TCP/UDP protocols, omitting ports creates an all-ports rule. CloudStack may represent this as empty start/end ports, 0/0, or 1/65535; the provider handles all formats.'

Suggested change

	be specified if the protocol is TCP or UDP. For TCP/UDP, omitting `ports` creates an all-ports rule. CloudStack may represent this as empty start/end, `0/0`, or `1/65535`; the provider handles all.
	be specified if the protocol is TCP or UDP. For TCP/UDP protocols, omitting `ports` creates an all-ports rule. CloudStack may represent this as empty start/end ports, `0/0`, or `1/65535`; the provider handles all formats.

[Copilot]

The comment has grammatical issues. Consider revising to: '// isAllPortsTCPUDP determines if a rule represents all ports for TCP/UDP protocols across CloudStack versions that may return 0/0, -1/-1, or 1/65535'

Suggested change

	// treats 'all ports' for tcp/udp across CS versions returning 0/0, -1/-1, or 1/65535
	// isAllPortsTCPUDP determines if a rule represents all ports for TCP/UDP protocols across CloudStack versions that may return 0/0, -1/-1, or 1/65535

[Copilot]

[nitpick] These comments are placed in an odd location within the validation logic. Consider moving them to the function-level documentation or closer to where the actual logic handles the omitted ports case for better code organization.