[CELEBORN-1743] Resolve the metrics data interruption and the job failure caused by locked resources #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lure caused by locked resources Remove the ConcurrentLinkedQueue and lock in AbstractSource which might cause the metrics data interruption and job fail. Current problems：[jira CELEBORN-1743](https://issues.apache.org/jira/browse/CELEBORN-1743) the lock in [[CELEBORN-1453]](apache#2548) might block the thread. No Manual test same result with CELEBORN-1453  Closes apache#2956 from zaynt4606/clb1743. Authored-by: zhengtao <[email protected]> Signed-off-by: Shuang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-0.5 #3005 +/- ##
==============================================
- Coverage 41.19% 41.16% -0.02%
==============================================
Files 226 226
Lines 14488 14503 +15
Branches 1308 1312 +4
==============================================
+ Hits 5967 5969 +2
- Misses 8179 8193 +14
+ Partials 342 341 -1 ☔ View full report in Codecov by Sentry. |
RexXiong
approved these changes
Dec 18, 2024
FMX
approved these changes
Dec 18, 2024
FMX
pushed a commit
that referenced
this pull request
Dec 18, 2024
…lure caused by locked resources …lure caused by locked resources Remove the ConcurrentLinkedQueue and lock in AbstractSource which might cause the metrics data interruption and job fail. Current problems：[jira CELEBORN-1743](https://issues.apache.org/jira/browse/CELEBORN-1743) the lock in [[CELEBORN-1453]](#2548) might block the thread. No Manual test same result with CELEBORN-1453  Closes #2956 from zaynt4606/clb1743. Authored-by: zhengtao <shuaizhentao.sztalibaba-inc.com> ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Closes #3005 from zaynt4606/branch-0.5-dev. Authored-by: zhengtao <[email protected]> Signed-off-by: mingji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lure caused by locked resources
Remove the ConcurrentLinkedQueue and lock in AbstractSource which might cause the metrics data interruption and job fail.
Current problems：jira CELEBORN-1743 the lock in [CELEBORN-1453] might block the thread.
No
Manual test
same result with CELEBORN-1453
Closes #2956 from zaynt4606/clb1743.
Authored-by: zhengtao [email protected]
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?