[CELEBORN-1768][WRITER] Refactoring Shuffle Writer to extract common methods #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. Do test this PR on the cluster, if something is missing, it will cause data correctness problems which are important. |
Well, i'll test normal and abnormal cases in yarn cluster laster. |
|
@zwangsheng Hi, How are your tests? |
Tested on yarn cluster, passing normal Terasort tests, as well as abnormal random task failure tests. But for the sake of correctness, I still need time to continue testing. |
|
Test the normal case(with terasort test) and the abnormal case(RDD with task fail), seems this change is safe. @FMX plz take a review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactoring shuffleWriters, extract common methods as BasedShuffleWriter.
Why are the changes needed?
Currently, HashBasedShuffleWriter and SortBasedShuffleWriter have a lot of the same methods, which makes it difficult for us to maintain the code. In many scenarios, we need to update multiple classes at the same time.
Therefore, we need to refactor Shuffle Writer, extract common methods without changing the specific method logic, and simplify the corresponding Shuffle Writer.
Does this PR introduce any user-facing change?
No, we do not change the logic code of apis or others.
How was this patch tested?
UT and local env