CASSANDRASC-89: Update Google Guice to 7.0.0 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smiklosovic
force-pushed
the
CASSANDRASC-89
branch
from
bb4a28a to
21ec2e2
Compare
frankgh
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
@smiklosovic we should probably run this through CI again. I was able to run this locally successfully. it seems bumping the guava-testlib helped with the ClassNofFound errors we saw in CI
smiklosovic
force-pushed
the
CASSANDRASC-89
branch
from
b3aae2b to
a4e133b
Compare
patch by Stefan Miklosovic; reviewed by Francisco Guerrero for CASSANDRASC-89
smiklosovic
force-pushed
the
CASSANDRASC-89
branch
from
a4e133b to
6661b7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch by Stefan Miklosovic; reviewed by TBD for CASSANDRASC-89