CASSJAVA-92: Local DC provided for nodetool clientstats #2036
Conversation
lukasz-antoniak
force-pushed
the
CASSJAVA-92
branch
from
d637315 to
1afcf84
Compare
| DefaultDriverOption.LOAD_BALANCING_LOCAL_DATACENTER); // DC from configuration | ||
| } | ||
| return dc; | ||
| } |
There was a problem hiding this comment.
DefaultDriverContext already defines lazy instantiation for (and access to) the startup options map for a given run. Rather than splitting the logic for determining the contents of a STARTUP message between DefaultDriverContext and this class the majority of the logic in this class should be consolidated into the existing DefaultDriverContext methods.
There was a problem hiding this comment.
I have noticed that and though that other entries of the STARTUP options are added here. The justification of the logic would be that all "dedicated" properties for STARTUP message are lazily instantiated where you pointed out, whereas all properties taken from other components (e.g. compression) are automatically injected in build() method.
| @@ -119,6 +122,12 @@ public Map<String, String> build() { | |||
| if (applicationVersion != null) { | |||
| builder.put(APPLICATION_VERSION_KEY, applicationVersion); | |||
| } | |||
| if (applicationLocalDc == null) { | |||
| applicationLocalDc = localDc(config); | |||
There was a problem hiding this comment.
config here is just the default profile but any profile can define a local datacenter... which in turn means we need to think about how execution profiles interact with this functionality.
I'm going to raise this point on the JIRA ticket; I think it warrants further discussion.
Fixes: CASSJAVA-92