Skip to content

Changelog and README updates for 1.7.0 #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
absurdfarce merged 1 commit into from
Sep 25, 2024
Merged

Changelog and README updates for 1.7.0 #1826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

## [1.7.0] - 2024-09-23

This release is the first after the donation of gocql to the Apache Software Foundation (ASF)

### Changed
- Update DRIVER_NAME parameter in STARTUP messages to a different value intended to clearly identify this
driver as an ASF driver. This should clearly distinguish this release (and future gocql-cassandra-driver
releases) from prior versions. (#1824)
Copy link
Author

@absurdfarce absurdfarce Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martin-sucha Does this wording make more sense to you? I tried to stay away from discussion about what the format of the string was (or is, for that matter) and focused more on the intent behind the change.

Copy link
Contributor

@martin-sucha martin-sucha Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is much better, thank you!

- Supported Go versions updated to 1.23 and 1.22 to conform to gocql's sunset model. (#1825)

## [1.6.0] - 2023-08-28

### Added
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ The following matrix shows the versions of Go and Cassandra that are tested with

| Go/Cassandra | 4.0.x | 4.1.x |
|--------------|-------|-------|
| 1.19 | yes | yes |
| 1.20 | yes | yes |
| 1.22 | yes | yes |
| 1.23 | yes | yes |

Gocql has been tested in production against many versions of Cassandra. Due to limits in our CI setup we only
test against the latest 2 GA releases.
Copy link
Author

@absurdfarce absurdfarce Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I debated about adding some text here about why we didn't include Cassandra 5.0.x here. We probably need at least a GH issue around support for 5.0.x before we call it good... and then there's the need to get vector support in as well. Anyways, in the end I decided not to include any additional text here but I'm very open to discussion on this point.

Copy link

@taaraora taaraora Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see, Cassandra 5 is partially supported and works with the driver - #1812. So, it can be added as a partially supported version. However, the vector type is not merged, and native protocol v4 should be used instead of v5 until it is merged.

Copy link
Author

@absurdfarce absurdfarce Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that's correct @taaraora. I fully expect the existing functionality of gocql will work pretty well with Cassandra 5.0.x. What concerns me is CASSANDRA-19906. We've been adding support for Cassandra 5.0.x to our test matrices for the other drivers DataStax maintains and we've hit an issue with precisely this problem on every one of them. The PR you reference doesn't have this concern because it also moves to testcontainers, but that's a change (a) I'm not entirely sold on and (b) I certainly don't want to take on in order to get 1.7.0 out the door.

Given all of that I was fine leaving 5.0.0 out for now. There's a fix to that issue coming in 5.0.1 so (barring some other major issue) I'd be fine with adding 5.0.1 to the existing setup once it's officially released (the vote is going on as I write this).

Make sense?

Expand Down