Cassandra 17594 attempt 2 #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_after_insert_wide_rows to wait for schema agreement
…e to downed nodes
maedhroz
approved these changes
May 17, 2022
|
test this please |
| @@ -85,6 +85,9 @@ def test_force_repair_range_async_1(self): | |||
| Collection<String> hosts, boolean fullRepair, | |||
| String... columnFamilies) | |||
| """ | |||
| self.fixture_dtest_setup.ignore_log_patterns = [ | |||
| 'Nothing to repair for' | |||
| ] | |||
There was a problem hiding this comment.
Can you provide a bit of info when we see this case and why it is ok to ignore it, please?
There was a problem hiding this comment.
This is the log we generate when we skip repair due to no data (or no tables, etc.); this test does not write data, so skipping repair is the expected behavior
There was a problem hiding this comment.
added docs explaining why; these tests do repairs for a token range, but doesn't put in effort to make sure that there are partitions in that range, so the repair aborts.
The test is checking logging, which is done after we parse arguments and print them... if repair doesn't happen these tests don't really care.
jonmeredith
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.