[CALCITE-6248] Illegal dates are accepted by casts

Signed-off-by: Mihai Budiu <[email protected]>

core/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java

@@ -653,6 +653,7 @@ private static void fraction(StringBuilder buf, int scale, long ms) {
   }
 
   public static int dateStringToUnixDate(String s) {
+    validateDate(s, s);
     int hyphen1 = s.indexOf('-');
     int y;
     int m;

core/src/test/java/org/apache/calcite/avatica/util/DateTimeUtilsTest.java

@@ -1681,6 +1681,12 @@ private static void assertThrows(Runnable runnable,
    * Test exception is raised if date in inappropriate meaning.
    */
   @Test public void testBrokenDate() {
+    // Test case for https://issues.apache.org/jira/browse/CALCITE-6248
+    // [CALCITE-6248] Illegal dates are accepted by casts
+    assertThrows(() -> DateTimeUtils.dateStringToUnixDate("2023-02-29"),
+        IllegalArgumentException.class,
+        is("Value of DAY field is out of range in '2023-02-29'"));
+
     // 2023 is not a leap year
     assertThrows(() ->
             DateTimeUtils.timestampStringToUnixDate("2023-02-29 12:00:00.123"),