Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-4209: Add backend API for AI Chat functionality #55

Merged
merged 37 commits into from
Aug 30, 2024

Conversation

@lhpqaq
Copy link
Member Author

lhpqaq commented Aug 27, 2024

sorry

@lhpqaq lhpqaq requested a review from kevinw66 August 28, 2024 02:54
@lhpqaq
Copy link
Member Author

lhpqaq commented Aug 28, 2024

@kevinw66 Some updates: diff

@lhpqaq lhpqaq requested a review from kevinw66 August 29, 2024 03:47
@lhpqaq lhpqaq closed this Aug 29, 2024
@lhpqaq lhpqaq reopened this Aug 29, 2024
@lhpqaq lhpqaq changed the title BIGTOP-4209: Add backend API for AI Chat functionality [WIP] BIGTOP-4209: Add backend API for AI Chat functionality Aug 29, 2024
@lhpqaq lhpqaq changed the title [WIP] BIGTOP-4209: Add backend API for AI Chat functionality BIGTOP-4209: Add backend API for AI Chat functionality Aug 29, 2024
@lhpqaq
Copy link
Member Author

lhpqaq commented Aug 29, 2024

PTAL @kevinw66

public class PlatformAuthorizedPO extends BasePO implements Serializable {

@Id
@GeneratedValue(strategy = GenerationType.TABLE, generator = "llm_platform_authorized_generator")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed

private Long userId;

@Column(name = "thread_id")
private Long chatThreadId;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use threadId instead

import java.util.List;

public interface ChatThreadDao extends BaseDao<ChatThreadPO> {
List<ChatThreadPO> findAllByUserId(@Param("user_id") Long userId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Param should use camelcase

@lhpqaq lhpqaq requested a review from kevinw66 August 30, 2024 02:58
Copy link
Contributor

@kevinw66 kevinw66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, thanks @lhpqaq

@kevinw66 kevinw66 merged commit 492c11d into apache:main Aug 30, 2024
5 checks passed
@lhpqaq lhpqaq deleted the bigtop-4209 branch December 20, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants