Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-4192: Switch ORM framework from JPA to MyBatis #54

Merged
merged 17 commits into from
Aug 29, 2024

Conversation

timyuer
Copy link
Contributor

@timyuer timyuer commented Aug 27, 2024

No description provided.

@kevinw66
Copy link
Contributor

How about we use xxxDao instead of xxxMapper to avoid user confusion with mapstruct, just like I did in BIGTOP-4172?

@kevinw66 kevinw66 changed the title Bigtop 4192: Switch ORM framework from JPA to MyBatis for Bigtop-Manager BIGTOP-4192: Switch ORM framework from JPA to MyBatis Aug 29, 2024
Copy link
Contributor

@kevinw66 kevinw66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, thanks @timyuer

@kevinw66 kevinw66 merged commit 1c84d15 into apache:main Aug 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants