BIGTOP-4173 : DDL file to create all related tables (MySQL) #27
Conversation
bigtop-manager-server/src/main/resources/ddl/MySQL-DDL-CREATE.sql
Outdated
Show resolved
Hide resolved
|
Looks like ci is failed, could you help fix it? |
CI Test builds without SkipTests and uses postgres as a meta db. There will be 2 possible resolutions
what do you think? which one seems better? |
|
How about we add skip tests on ci.yml? we can add a separate job to run ut after we have some ut cases |
|
BTW, I think we need to add a sql to insert default admin user here, |
|
@kevinw66 I agree with your idea adding SkipTests and unit tests later. but for now, it will be really helpful that CI include build and test.(even just executing server) so I prefer leaving ddl-generation 'create-or-extend-tables' for now. inserting default admin user will be good for testing, I will add another insert query. |
Sounds good! |
| @@ -22,24 +22,49 @@ | |||
| -- DROP DATABASE IF EXISTS `ambari`; | |||
| -- DROP USER `ambari`; | |||
|
|
||
| # USE @schema; | ||
| # | ||
| USE @schema; |
There was a problem hiding this comment.
New problems here after we reformat these lines
There was a problem hiding this comment.
oops, my IDE did that i will correct this.
| set | ||
| @minor = cast(substring_index(@version_short, '.', -1) as SIGNED); | ||
| set | ||
| @engine_stmt = IF((@major >= 5 AND @minor>=6) or @major >= 8, 'SET default_storage_engine=INNODB', 'SET storage_engine=INNODB'); |
There was a problem hiding this comment.
I think we shouldn't reformat these also
No description provided.