Skip to content

Commit

Permalink
BIGTOP-4154: Support streaming shell output into task log (#15)
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinw66 authored Jul 9, 2024
1 parent d053a9d commit fb10260
Show file tree
Hide file tree
Showing 2 changed files with 58 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
*/
package org.apache.bigtop.manager.common.shell;

import org.apache.bigtop.manager.common.thread.TaskLogThreadDecorator;

import lombok.extern.slf4j.Slf4j;

import java.io.BufferedReader;
Expand Down Expand Up @@ -305,23 +307,20 @@ private BufferedReader createBufferedReader(InputStream inputStream) {
}

private Thread createReaderThread(BufferedReader reader, StringBuilder msg) {
return new Thread() {

@Override
public void run() {
try {
String line = reader.readLine();
while ((line != null) && !isInterrupted()) {
consumer.accept(line);
msg.append(line);
msg.append(System.lineSeparator());
line = reader.readLine();
}
} catch (IOException ioe) {
log.warn("Error reading the stream", ioe);
TaskLogThreadDecorator decorator = new TaskLogThreadDecorator();
return decorator.decorate(() -> {
try {
String line = reader.readLine();
while ((line != null)) {
consumer.accept(line);
msg.append(line);
msg.append(System.lineSeparator());
line = reader.readLine();
}
} catch (IOException ioe) {
log.warn("Error reading the stream", ioe);
}
};
});
}

private void scheduleTimeoutTimer() {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.bigtop.manager.common.thread;

import org.apache.commons.lang3.StringUtils;

import org.slf4j.MDC;

import jakarta.annotation.Nonnull;

public class TaskLogThreadDecorator {

public Thread decorate(@Nonnull Runnable runnable) {
String taskId = MDC.get("taskId");
if (StringUtils.isNotBlank(taskId)) {
return new Thread(() -> {
try {
MDC.put("taskId", taskId);
runnable.run();
} finally {
MDC.clear();
}
});
} else {
return new Thread(runnable);
}
}
}

0 comments on commit fb10260

Please sign in to comment.