Skip to content

chore: fix typo of EMA_ALPHA in MQTTSessionHandler #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
popduke merged 2 commits into from
Dec 17, 2025
Merged

chore: fix typo of EMA_ALPHA in MQTTSessionHandler #209

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5600aaa
chore: fix typo of EMA_ALPHA in MQTTSessionHandler
hezhangjian Dec 17, 2025
c92f1e0
Merge branch 'main' into alpha-typo
popduke Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...bifromq-mqtt-server/src/main/java/org/apache/bifromq/mqtt/handler/MQTTSessionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
@Slf4j
public abstract class MQTTSessionHandler extends MQTTMessageHandler implements IMQTTSession {
protected static final boolean SANITY_CHECK = SanityCheckMqttUtf8String.INSTANCE.get();
private static final double EMA_APLHA = 0.15;
private static final double EMA_ALPHA = 0.15;
private static final int REDIRECT_CHECK_INTERVAL_SECONDS = ClientRedirectCheckIntervalSeconds.INSTANCE.get();
protected final TenantSettings settings;
protected final String userSessionId;
Expand Down Expand Up @@ -370,7 +370,7 @@ public void handlerAdded(ChannelHandlerContext ctx) {
ChannelAttrs.trafficShaper(ctx).setWriteLimit(settings.outboundBandwidth);
ChannelAttrs.trafficShaper(ctx).setMaxWriteSize(settings.outboundBandwidth);
ChannelAttrs.setMaxPayload(settings.maxPacketSize, ctx);
receiveQuota = new AdaptiveReceiveQuota(settings.minSendPerSec, clientReceiveMaximum(), EMA_APLHA);
receiveQuota = new AdaptiveReceiveQuota(settings.minSendPerSec, clientReceiveMaximum(), EMA_ALPHA);
sessionCtx.localSessionRegistry.add(channelId(), this);
sessionRegistration = ChannelAttrs.mqttSessionContext(ctx).sessionDictClient
.reg(clientInfo, (killer, redirection) -> {
Expand Down
Loading