Skip to content

Conversation

@Suvrat1629
Copy link
Contributor

Please add a meaningful description for your change here


This PR fixes #28438 where BigQuery operations would retry indefinitely when trying to access a non-existent dataset.

The BigQueryHelpers.getDatasetLocation() method was wrapping all exceptions (including IOException from dataset-not-found errors) in RuntimeException. This caused the retry mechanism in PendingJob.runJob() to treat dataset lookup failures as retryable job execution errors, leading to infinite retries that ignored the configured MAX_RPC_RETRIES limit of 9.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Suvrat1629, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical flaw in BigQuery integration where attempts to query or manipulate non-existent datasets resulted in an infinite retry loop, consuming resources and masking the true error. The changes refactor the exception handling within the BigQueryHelpers.getDatasetLocation() method and its consumers, ensuring that dataset-not-found errors are now correctly identified and immediately propagated as specific exceptions, thereby preventing indefinite retries and providing more actionable feedback to users.

Highlights

  • Resolved Infinite Retry Issue: Fixed a bug where BigQuery operations would endlessly retry when attempting to access a non-existent dataset, previously identified as issue [Bug]: Dataflow keeps retrying to obtain an already deleted BigQuery dataset #28438.
  • Improved Exception Handling: The BigQueryHelpers.getDatasetLocation() method now explicitly throws IOException and InterruptedException, instead of wrapping all exceptions in a generic RuntimeException.
  • Specific Error Messaging: Calling methods (UpdateSchemaDestination, WriteRename, WriteTables) now catch these specific exceptions and provide clearer error messages, particularly for "dataset not found" scenarios, preventing infinite retries.
  • New Unit Tests: Added unit tests for BigQueryHelpers.getDatasetLocation() to verify correct exception propagation for non-existent datasets and proper location retrieval for valid ones.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers:

R: @chamikaramj for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Suvrat1629
Copy link
Contributor Author

@chamikaramj Gentle ping, please take a look.
Thank you.

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @chamikaramj

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @Abacn

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

Reminder, please take a look at this pr: @chamikaramj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Dataflow keeps retrying to obtain an already deleted BigQuery dataset

1 participant