GH-50796: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_valgrind.sh

[hiroyuki-sato]

Rationale for this change

This is the sub issue #44748.

• SC2046: Quote this to prevent word splitting.
• SC2086: Double quote to prevent globbing and word splitting.
• SC2223: This default assignment may cause DoS due to globbing. Quote it.

shellcheck ci/scripts/r_valgrind.sh

In ci/scripts/r_valgrind.sh line 21:
: ${R_BIN:=RDvalgrind}
  ^------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.


In ci/scripts/r_valgrind.sh line 27:
pushd ${source_dir}
      ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
pushd "${source_dir}"


In ci/scripts/r_valgrind.sh line 31:
${R_BIN} CMD INSTALL ${INSTALL_ARGS} arrow*.tar.gz
                     ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
${R_BIN} CMD INSTALL "${INSTALL_ARGS}" arrow*.tar.gz


In ci/scripts/r_valgrind.sh line 42:
if [ $(grep -c "ERROR SUMMARY: 0 errors" testthat.out) != 1 ]; then
     ^-- SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
  https://www.shellcheck.net/wiki/SC2223 -- This default assignment may cause...

What changes are included in this PR?

• SC2046: Quote variable to prevent word splitting.
• SC2086: Quote variable
• SC2223: Quote default variable assignments.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

• GitHub Issue: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_valgrind.sh #50796

[github-actions]

⚠️ GitHub issue #50796 has been automatically assigned in GitHub to PR creator.

[hiroyuki-sato]

@github-actions crossbow submit test-r-linux-valgrind

[github-actions]

Revision: 397dd46

Submitted crossbow builds: ursacomputing/crossbow @ actions-4f596c72c9

Task	Status
test-r-linux-valgrind

[hiroyuki-sato]

https://github.com/ursacomputing/crossbow/actions/runs/30874057795/job/91881785985#step:6:23742

t looks like ${INSTALL_ARGS} is not set. I’ll try converting the variable into an array.

R CMD INSTALL '' arrow_25.0.0.9000.tar.gz

[hiroyuki-sato]

@github-actions crossbow submit test-r-linux-valgrind

[github-actions]

Revision: a41f6ca

Submitted crossbow builds: ursacomputing/crossbow @ actions-088bc54f02

Task	Status
test-r-linux-valgrind

[hiroyuki-sato]

@github-actions crossbow submit test-r-linux-valgrind

[github-actions]

Revision: 3c3e577

Submitted crossbow builds: ursacomputing/crossbow @ actions-3134197238

Task	Status
test-r-linux-valgrind

[kou]

+1

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 906bc0a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.