GH-50779: [C++][Parquet] Replace remaining RapidJSON usage with simdjson - #50781
GH-50779: [C++][Parquet] Replace remaining RapidJSON usage with simdjson#50781Reranko05 wants to merge 2 commits into
Conversation
|
|
d026d1f to
0230946
Compare
|
I'm migrating
With RapidJSON this was straightforward because the DOM is reusable, but with Is the expected approach here to restructure the code into a single pass, or is there another way to serialize an already-inspected Thanks! |
|
As per docs here you could probably use the // Inspect crs_object...
// If it was not a recognized lon/lat CRS:
ARROW_ASSIGN_OR_RAISE(
auto ignored,
::arrow::internal::GetSimdjsonResult(
crs_object.reset(), "Failed to reset 'crs' object: "));
ARROW_ASSIGN_OR_RAISE(
auto raw_crs,
::arrow::internal::GetSimdjsonResult(
crs_object.raw_json(), "Failed to get raw 'crs' JSON: "));
return std::string(raw_crs);Check also |
|
Thanks @rok, However, one test still fails because Would you prefer keeping the previous compact formatting or preserving the original JSON formatting? |
|
@Reranko05 let's avoid behavior changes. Perhaps we can use simdjson::minify? |
270af67 to
777999e
Compare
Rationale for this change
This PR continues the simdjson migration by replacing the remaining RapidJSON usages under
cpp/src/parquetwith simdjson andJsonWriter. It also removes the remaining unnecessary RapidJSON dependencies from the Parquet test target and Meson build configuration.What changes are included in this PR?
reader_test.ccwith simdjson.geospatial/util_json_internal.ccwith simdjson andJsonWriter.types.ccwithJsonWriter.rapidjson_depdependency fromcpp/src/parquet/meson.build.CMakeLists.txt.