GH-50472: [C++][Gandiva] fix integer overflow in mask output allocation#50473
Open
Arawoof06 wants to merge 1 commit into
Open
GH-50472: [C++][Gandiva] fix integer overflow in mask output allocation#50473Arawoof06 wants to merge 1 commit into
Arawoof06 wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
mask_utf8_utf8_utf8_utf8sizes its output arena buffer withstd::max(upper_length, lower_length, num_length) * data_leninint32_t. The replacement lengths and the input length both come from the SQLmaskarguments, so a large replacement combined with a large input wraps the multiply and yields a smallmax_length. The masking loop then writes each replacement past the undersized allocation. Withdata_len = 65536and a 65537-byte replacement the true size is 4,295,032,832 which truncates to 65536, and the first masked character already overruns the buffer, crashing with SIGSEGV.What changes are included in this PR?
Compute the size with
arrow::internal::MultiplyWithOverflowand return an error when it overflows, the same guardrepeat_utf8_int32,to_hex_binary, and the multibytetranslatepath already use.Are these changes tested?
Yes. Added a case to
TestGdvFnStubs.TestMaskthat passes a 64 KiB input with a 64 KiB+1 replacement; it crashes before the change and now returns an error with the fix.Are there any user-facing changes?
maskon inputs whose masked size would exceedINT32_MAXnow returns an error instead of crashing.This PR contains a "Critical Fix". It fixes a heap buffer overflow (crash) reachable from the
maskSQL function on large inputs.