GH-50439: Add ArrowFormat::{,Large}{Binary,UTF8}Array.new(values)#50452
Merged
Conversation
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Ruby-side convenience construction for variable-size binary and UTF-8 ArrowFormat arrays by allowing ArrowFormat::{,Large}{Binary,UTF8}Array.new(values) to build the underlying buffers directly from a Ruby values list.
Changes:
- Extend
VariableSizeBinaryArrayinitialization to accept a singlevaluesargument and build validity/offsets/values buffers internally. - Add new test coverage for initialization and equality behavior (including sliced arrays) across Binary/LargeBinary/UTF8/LargeUTF8 array classes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ruby/red-arrow-format/lib/arrow-format/array.rb | Adds new(values) support by building buffers for variable-size binary/UTF8 arrays. |
| ruby/red-arrow-format/test/test-binary-array.rb | Introduces tests covering construction and equality (including slicing) for the new initializer behavior. |
Reranko05
force-pushed
the
gh-50439-binary-array-new
branch
from
b50f0cd to
962d0d1
Compare
github-actions
Bot
added
awaiting committer review
|
|
kou
reviewed
Jul 10, 2026
github-actions
Bot
added
awaiting changes
Reranko05
force-pushed
the
gh-50439-binary-array-new
branch
from
962d0d1 to
da499a5
Compare
github-actions
Bot
added
awaiting change review
Reranko05
force-pushed
the
gh-50439-binary-array-new
branch
from
da499a5 to
cd25366
Compare
kou
approved these changes
Jul 10, 2026
github-actions
Bot
added
awaiting merge
Signed-off-by: Aaditya Srinivasan <aadityasri03@gmail.com>
Reranko05
force-pushed
the
gh-50439-binary-array-new
branch
from
cd25366 to
67fd826
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Building variable-size binary Arrow arrays from Ruby objects is convenient.
What changes are included in this PR?
Accept:
ArrowFormat::BinaryArray.new(values)ArrowFormat::LargeBinaryArray.new(values)ArrowFormat::UTF8Array.new(values)ArrowFormat::LargeUTF8Array.new(values)Are these changes tested?
Yes.
Added tests for:
nilAre there any user-facing changes?
Yes.
ArrowFormat::{,Large}{Binary,UTF8}Array.new(values)#50439