Skip to content

GH-50417: [CI][Dev] Fix shellcheck error in ci/scripts/install_bison.sh#50418

Merged
kou merged 1 commit into
apache:mainfrom
hiroyuki-sato:topic/shellcheck-install_bison
Jul 8, 2026
Merged

GH-50417: [CI][Dev] Fix shellcheck error in ci/scripts/install_bison.sh#50418
kou merged 1 commit into
apache:mainfrom
hiroyuki-sato:topic/shellcheck-install_bison

Conversation

@hiroyuki-sato

@hiroyuki-sato hiroyuki-sato commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Rationale for this change

Fix shellcheck errors in ci/scripts/install_bison.sh

This is the sub issue #44748.

  • SC2046: Quote this to prevent word splitting
In ci/scripts/install_bison.sh line 37:
make -j$(nproc)
       ^------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

What changes are included in this PR?

  • SC2046: Quota variable.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

⚠️ GitHub issue #50417 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions Bot added the awaiting review Awaiting review label Jul 8, 2026

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions Bot removed the awaiting review Awaiting review label Jul 8, 2026
@kou kou merged commit 8e574ad into apache:main Jul 8, 2026
38 checks passed
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Jul 8, 2026
@kou kou removed the awaiting merge Awaiting merge label Jul 8, 2026
@hiroyuki-sato hiroyuki-sato deleted the topic/shellcheck-install_bison branch July 9, 2026 03:27
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8e574ad.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants