Skip to content

GH-50403: [C++] Remove ArrayBuilder::AppendToBitmap #50404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 1 commit into from
Jul 7, 2026
+0 −28
Merged

GH-50403: [C++] Remove ArrayBuilder::AppendToBitmap #50404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions cpp/src/arrow/array/builder_base.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,24 +67,6 @@ Status ArrayBuilder::TrimBuffer(const int64_t bytes_filled, ResizableBuffer* buf
return Status::OK();
}

Status ArrayBuilder::AppendToBitmap(bool is_valid) {
RETURN_NOT_OK(Reserve(1));
UnsafeAppendToBitmap(is_valid);
return Status::OK();
}

Status ArrayBuilder::AppendToBitmap(const uint8_t* valid_bytes, int64_t length) {
RETURN_NOT_OK(Reserve(length));
UnsafeAppendToBitmap(valid_bytes, length);
return Status::OK();
}

Status ArrayBuilder::AppendToBitmap(int64_t num_bits, bool value) {
RETURN_NOT_OK(Reserve(num_bits));
UnsafeAppendToBitmap(num_bits, value);
return Status::OK();
}

Status ArrayBuilder::Resize(int64_t capacity) {
RETURN_NOT_OK(CheckCapacity(capacity));
capacity_ = capacity;
Expand Down
10 changes: 0 additions & 10 deletions cpp/src/arrow/array/builder_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,16 +207,6 @@ class ARROW_EXPORT ArrayBuilder {
virtual std::shared_ptr<DataType> type() const = 0;

protected:
/// Append to null bitmap
Status AppendToBitmap(bool is_valid);

/// Vector append. Treat each zero byte as a null. If valid_bytes is null
/// assume all of length bits are valid.
Status AppendToBitmap(const uint8_t* valid_bytes, int64_t length);

/// Uniform append. Append N times the same validity bit.
Status AppendToBitmap(int64_t num_bits, bool value);

/// Set the next length bits to not null (i.e. valid).
Status SetNotNull(int64_t length);

Expand Down
Loading