GH-50302: [GLib][Ruby][FlightRPC] Add missing references for GC#50401
Open
kou wants to merge 1 commit into
Open
GH-50302: [GLib][Ruby][FlightRPC] Add missing references for GC#50401kou wants to merge 1 commit into
kou wants to merge 1 commit into
Conversation
|
|
github-actions
Bot
added
Component: GLib
awaiting committer review
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GLib Arrow Flight server binding to retain a reference to the GAFlightServerOptions passed to gaflight_server_listen(), preventing the options (and indirectly the auth handler object graph) from being freed while the server is still alive.
Changes:
- Store
GAFlightServerOptions*inGAFlightServerPrivateand keep it referenced across the server lifetime. - Add a
disposeimplementation to release the stored options reference when the server object is torn down. - Update
gaflight_server_listen()to replace the stored options reference on each listen.
Comment on lines
+1254
to
+1259
| auto priv = GAFLIGHT_SERVER_GET_PRIVATE(server); | ||
| if (priv->options) { | ||
| g_object_unref(priv->options); | ||
| } | ||
| priv->options = options; | ||
| g_object_ref(priv->options); |
kou
force-pushed
the
glib-flight-listen-gc
branch
from
3b0771c to
3df3a78
Compare
kou
force-pushed
the
glib-flight-listen-gc
branch
from
3df3a78 to
8f41f6b
Compare
Comment on lines
+1205
to
+1208
| if (priv->options) { | ||
| g_object_unref(priv->options); | ||
| priv->options = nullptr; | ||
| } |
Comment on lines
+1254
to
+1261
| auto priv = GAFLIGHT_SERVER_GET_PRIVATE(server); | ||
| if (priv->options != options) { | ||
| g_object_ref(priv->options); | ||
| if (priv->options) { | ||
| g_object_unref(priv->options); | ||
| } | ||
| priv->options = options; | ||
| } |
kou
force-pushed
the
glib-flight-listen-gc
branch
from
8f41f6b to
853822b
Compare
kou
force-pushed
the
glib-flight-listen-gc
branch
from
853822b to
8239181
Compare
Comment on lines
+1205
to
+1209
| if (priv->options) { | ||
| g_object_unref(priv->options); | ||
| priv->options = nullptr; | ||
| } | ||
|
|
Comment on lines
136
to
139
| macos: | ||
| name: ARM64 macOS GLib & Ruby | ||
| runs-on: macos-latest | ||
| runs-on: macos-26 | ||
| if: ${{ !contains(github.event.pull_request.title, 'WIP') }} |
kou
force-pushed
the
glib-flight-listen-gc
branch
from
8239181 to
df02f37
Compare
kou
changed the title
gaflight_server_listen()
kou
force-pushed
the
glib-flight-listen-gc
branch
from
df02f37 to
632f010
Compare
Comment on lines
+1203
to
+1208
| auto priv = GAFLIGHT_SERVER_GET_PRIVATE(object); | ||
|
|
||
| if (priv->options) { | ||
| g_object_unref(priv->options); | ||
| priv->options = nullptr; | ||
| } |
Comment on lines
+39
to
+45
| env | sort | ||
|
|
||
| run_test_args=() | ||
| if [ -n "${RUNNER_DEBUG}" ]; then | ||
| run_test_args+=(-v) | ||
| fi | ||
| ruby test/run-test.rb "${run_test_args[@]}" |
Comment on lines
136
to
139
| macos: | ||
| name: ARM64 macOS GLib & Ruby | ||
| runs-on: macos-latest | ||
| runs-on: macos-26 | ||
| if: ${{ !contains(github.event.pull_request.title, 'WIP') }} |
kou
force-pushed
the
glib-flight-listen-gc
branch
2 times, most recently
from
eab1c4a to
e5960c4
Compare
… `gaflight_server_listen()` `gaflight_server_listen()` may use options' auth handler later. So we should refer the given options while the server is alive.
kou
force-pushed
the
glib-flight-listen-gc
branch
from
e5960c4 to
1306697
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
gaflight_server_listen()may use options' auth handler later. So we should refer the given options while the server is alive. If we don't refer the given options, we may touch freed auth handler later.The argument of
ArrowFlight::Criteria.new/ArrowFlight::Ticket.newshould be referred to protect from GC in Ruby.What changes are included in this PR?
gaflight_server_listen()ArrowFlight::Criteria.newArrowFlight::Ticket.newAre these changes tested?
Yes.
Are there any user-facing changes?
Yes.