Skip to content

GH-50399: [C++][Gandiva] Use timegm in DaysSince helper in Gandiva date_time_test #50400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoeba merged 1 commit into from
Jul 8, 2026
Merged

GH-50399: [C++][Gandiva] Use timegm in DaysSince helper in Gandiva date_time_test #50400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/src/gandiva/tests/date_time_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ int32_t DaysSince(time_t base_line, int32_t yy, int32_t mm, int32_t dd, int32_t
given_ts.tm_min = min;
given_ts.tm_sec = sec;

time_t ts = mktime(&given_ts);
time_t ts = timegm(&given_ts);
if (ts == static_cast<time_t>(-1)) {
ARROW_LOG(FATAL) << "mktime() failed";
ARROW_LOG(FATAL) << "timegm() failed";
}
// time_t is an arithmetic type on both POSIX and Windows, we can simply
// subtract to get a duration in seconds.
Expand Down
Loading