Skip to content

MINOR: [R] Adjust parallel::detectCores if NA to not break --parallel input in CMake #50317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rok merged 13 commits into from
Jul 6, 2026
+2 −1
Merged

MINOR: [R] Adjust parallel::detectCores if NA to not break --parallel input in CMake #50317

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ef59f03
gmake parsing issue
rok Jul 1, 2026
4f135a1
Potential fix for pull request finding
rok Jul 1, 2026
ae00aea
review feedback
rok Jul 2, 2026
f217bd2
Fix -j flag earlier
rok Jul 2, 2026
7999054
another attempt
rok Jul 2, 2026
a623cf5
another attempt
rok Jul 2, 2026
ca8919f
unset + env
rok Jul 3, 2026
4c7c074
sanitize and print
rok Jul 3, 2026
cf523e8
fix NA
rok Jul 3, 2026
6aa0fe6
bash sanitize
rok Jul 3, 2026
5a5ea93
minimal fix
rok Jul 3, 2026
8f4ba35
minimal-er fix
rok Jul 3, 2026
8f07878
Apply suggestion from @rok
rok Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion r/inst/build_arrow_static.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
-G "${CMAKE_GENERATOR:-Unix Makefiles}" \
${SOURCE_DIR}

${CMAKE} --build . --target install -- -j $N_JOBS
(unset MAKEFLAGS MFLAGS; ${CMAKE} --build . --target install -- -j "${N_JOBS}")
Comment thread
rok marked this conversation as resolved.
Outdated

if command -v sccache &> /dev/null; then
echo "=== sccache stats after the build ==="
Expand Down
Loading