Skip to content

GH-50300: [C++][CI] Update include to generated/Message_generated.h so Meson is able to find #50301

Merged
kou merged 2 commits into
apache:mainfrom
raulcd:GH-50300
Jul 1, 2026
Merged

GH-50300: [C++][CI] Update include to generated/Message_generated.h so Meson is able to find #50301
kou merged 2 commits into
apache:mainfrom
raulcd:GH-50300

Conversation

@raulcd

@raulcd raulcd commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Rationale for this change

The meson job is currently failing due to not finding header for include on flatbuffers generated file. This works on CMake because we have: include_directories(src/generated) and didn't failed previously on Meson because we use the full generated/xxx.h path to the files on includes.

What changes are included in this PR?

Add generated in the include so meson can also find the header without requiring to include directory.
Remove include_directories(src/generated) on CMake to match Meson configuration.

Are these changes tested?

Yes, via CI

Are there any user-facing changes?

No

@raulcd raulcd added the CI: Extra: C++ Run extra C++ CI label Jun 30, 2026
@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Jun 30, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@raulcd raulcd changed the title [C++][CI] Add flatbuffers generated path to include to fix meson build GH-50300: [C++][CI] Add flatbuffers generated path to include to fix meson build Jun 30, 2026
@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

⚠️ GitHub issue #50300 has been automatically assigned in GitHub to PR creator.

@raulcd

raulcd commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

The meson job is currently successful.

@raulcd

raulcd commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit wheel-manylinux-2-28-cp314-cp314-amd64

@raulcd

raulcd commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

The crossbow submit job is unrelated. I am trying to reproduce an issue that happened on the nightlies which I can't reproduce locally, see for more details:

@raulcd raulcd marked this pull request as ready for review June 30, 2026 09:46
@raulcd raulcd requested a review from pitrou as a code owner June 30, 2026 09:46
Copilot AI review requested due to automatic review settings June 30, 2026 09:46
@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown

Revision: 0811c9d

Submitted crossbow builds: ursacomputing/crossbow @ actions-6f1f900867

Task Status
wheel-manylinux-2-28-cp314-cp314-amd64 GitHub Actions

Copilot AI reviewed Jun 30, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses the Meson CI failure in the C++ build where a Flatbuffers-generated header (Message_generated.h) could not be found during compilation of IPC tests.

Changes:

  • Update message_internal_test.cc to include the Flatbuffers-generated header via the generated/ subdirectory path.

Comment thread cpp/src/arrow/ipc/message_internal_test.cc
@raulcd raulcd changed the title GH-50300: [C++][CI] Add flatbuffers generated path to include to fix meson build GH-50300: [C++][CI] Update include path so Meson is able to find generated/Message_generated.h Jun 30, 2026
@raulcd raulcd requested a review from Copilot June 30, 2026 09:54
Copilot AI reviewed Jun 30, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread cpp/src/arrow/ipc/message_internal_test.cc
@pitrou

pitrou commented Jun 30, 2026

Copy link
Copy Markdown
Member

Do we want to remove include_directories(src/generated) so as to make the CMake and Meson setups more similar?

@raulcd raulcd mentioned this pull request Jun 30, 2026
Closed
@raulcd raulcd changed the title GH-50300: [C++][CI] Update include path so Meson is able to find generated/Message_generated.h GH-50300: [C++][CI] Update include to generated/Message_generated.h so Meson is able to find Jun 30, 2026
@raulcd

raulcd commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

Do we want to remove include_directories(src/generated) so as to make the CMake and Meson setups more similar?

Makes sense to me, I've pushed the removal of the include_directories.

kou
kou approved these changes Jul 1, 2026
View reviewed changes

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 0cf9e03 into apache:main Jul 1, 2026
86 of 91 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Jul 1, 2026
@kou kou mentioned this pull request Jul 1, 2026
Closed
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Jul 1, 2026
@conbench-apache-arrow

conbench-apache-arrow Bot commented Jul 1, 2026

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0cf9e03.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@kou kou kou approved these changes
@pitrou pitrou pitrou approved these changes

Assignees

No one assigned

Labels

awaiting merge Awaiting merge CI: Extra: C++ Run extra C++ CI Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raulcd @pitrou @kou