GH-50197: [C++][Python] Add "hypot" compute kernel by shrivasshankar · Pull Request #50198 · apache/arrow

shrivasshankar · 2026-06-16T16:21:58Z

Rationale for this change

Arrow has atan2 and logb but no hypot. Computing a Euclidean norm currently needs sqrt(add(multiply(x, x), multiply(y, y))), which can overflow at the multiply step even when the result is representable.

What changes are included in this PR?

Add a hypot kernel backed by std::hypot (float32/float64, with integer/decimal inputs promoted to float64), the Hypot() C++ function, a FunctionDoc and compute.rst entry, and a Python expression test. pc.hypot is auto-exposed from the registry.

Are these changes tested?

Yes, C++ tests for the basic cases, null/NaN/Inf handling, and an overflow case confirming it doesn't fall back to a naive sqrt(x*x + y*y).

Are there any user-facing changes?

Yes, a new hypot function in C++ and Python. Additive only.

GitHub Issue: [C++][Python] Add "hypot" compute kernel #50197

github-actions · 2026-06-16T16:23:33Z

⚠️ GitHub issue #50197 has no components, please add labels for components.

shrivasshankar · 2026-06-21T22:43:35Z

i rebased on main @pitrou could you check this out

rok · 2026-06-24T13:42:15Z

This looks good. Consider adding hypot to the python docs too:

arrow/docs/source/python/api/compute.rst

Lines 161 to 181 in 12b3eda

    
           Trigonometric Functions 
        
           ----------------------- 
        
           Trigonometric functions are also supported, and also offer ``_checked`` 
        
           variants which detect domain errors where appropriate. 
        
           .. autosummary:: 
        
              :toctree: ../generated/ 
        
              acos 
        
              acos_checked 
        
              asin 
        
              asin_checked 
        
              atan 
        
              atan2 
        
              cos 
        
              cos_checked 
        
              sin 
        
              sin_checked 
        
              tan 
        
              tan_checked

shrivasshankar · 2026-06-28T21:38:52Z

This looks good. Consider adding hypot to the python docs too:

arrow/docs/source/python/api/compute.rst

Lines 161 to 181 in 12b3eda

Trigonometric Functions

-----------------------

Trigonometric functions are also supported, and also offer ``_checked``

variants which detect domain errors where appropriate.

.. autosummary::

:toctree: ../generated/

acos

acos_checked

asin

asin_checked

atan

atan2

cos

cos_checked

sin

sin_checked

tan

tan_checked

added hypot to the python compute docs and rebased on main. Thanks for the review!

rok

This looks good. @pitrou could you do a pass?

rok · 2026-06-29T18:44:25Z

@shrivasshankar I don't think the failures are related. Could you try rebasing?

shrivasshankar · 2026-06-29T20:19:45Z

@shrivasshankar I don't think the failures are related. Could you try rebasing?

I rebased and it has to rerun

Add a binary floating-point compute function "hypot" that computes the hypotenuse sqrt(x^2 + y^2) without undue overflow or underflow at intermediate stages, mirroring numpy.hypot and std::hypot. The kernel reuses the existing MakeArithmeticFunctionFloatingPoint factory (as atan2 does), registering float32 and float64 kernels and promoting integer/decimal inputs to float64 via DispatchBest. Also adds the Hypot() convenience function and declaration, a FunctionDoc, C++ tests (including an overflow-safety test that exercises inputs whose squares overflow float32), a compute.rst entry, and pyarrow expression coverage.

rok

I think this is good to go if CI passes.

Co-authored-by: Rok Mihevc <rok@mihevc.org>

shrivasshankar · 2026-06-29T23:22:49Z

I think this is good to go if CI passes.

sounds good applying ur suggestion reset the CI again

shrivasshankar · 2026-06-30T00:42:01Z

@rok all pass besides 1 which seems to be a runner crash not a test failure

rok · 2026-06-30T09:46:07Z

@pitrou I think this is ready to go, if you can please take a final look, I'd like to merge for this release.

rok · 2026-06-30T21:29:56Z

@shrivasshankar would you consider adding two tests?

rok

Would like to add the two test cases before merging.

Co-authored-by: Rok Mihevc <rok@mihevc.org>

shrivasshankar · 2026-07-01T00:12:00Z

I added the 2 tests @rok

rok · 2026-07-01T01:13:09Z

Thanks for working on this @shrivasshankar !

shrivasshankar requested review from AlenkaF, pitrou, raulcd and rok as code owners June 16, 2026 16:21

github-actions Bot added the awaiting review Awaiting review label Jun 16, 2026

github-actions Bot added Component: C++ Component: Python Component: Documentation labels Jun 16, 2026

shrivasshankar force-pushed the feature/add-hypot-kernel branch from 1978af2 to 9568a77 Compare June 21, 2026 22:23

shrivasshankar closed this Jun 21, 2026

shrivasshankar reopened this Jun 21, 2026

rok reviewed Jun 24, 2026

View reviewed changes

Comment thread cpp/src/arrow/compute/kernels/scalar_arithmetic.cc Outdated

shrivasshankar force-pushed the feature/add-hypot-kernel branch from 9568a77 to 7e74a4c Compare June 28, 2026 21:32

github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jun 28, 2026

rok approved these changes Jun 28, 2026

View reviewed changes

shrivasshankar force-pushed the feature/add-hypot-kernel branch from 7e74a4c to bd4b80c Compare June 29, 2026 20:19

shrivasshankar requested a review from rok June 29, 2026 20:31

rok reviewed Jun 29, 2026

View reviewed changes

Comment thread python/pyarrow/tests/test_compute.py Outdated

github-actions Bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jun 29, 2026

shrivasshankar force-pushed the feature/add-hypot-kernel branch from bd4b80c to 6168525 Compare June 29, 2026 23:13

github-actions Bot removed the awaiting changes Awaiting changes label Jun 29, 2026

github-actions Bot added the awaiting change review Awaiting change review label Jun 29, 2026

rok reviewed Jun 29, 2026

View reviewed changes

Comment thread python/pyarrow/tests/test_compute.py Outdated

github-actions Bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jun 29, 2026

rok approved these changes Jun 29, 2026

View reviewed changes

Update python/pyarrow/tests/test_compute.py

fd3a659

Co-authored-by: Rok Mihevc <rok@mihevc.org>

github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 29, 2026

rok reviewed Jun 30, 2026

View reviewed changes

Comment thread cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc

rok reviewed Jun 30, 2026

View reviewed changes

Comment thread cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc Outdated

rok approved these changes Jun 30, 2026

View reviewed changes

shrivasshankar and others added 2 commits June 30, 2026 19:06

Update cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc

040ef0e

Co-authored-by: Rok Mihevc <rok@mihevc.org>

Update cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc

bf47537

Co-authored-by: Rok Mihevc <rok@mihevc.org>

rok reviewed Jul 1, 2026

View reviewed changes

Comment thread cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc Outdated

Update cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc

805aec4

rok merged commit 5d2a8fa into apache:main Jul 1, 2026
60 checks passed

rok removed the awaiting change review Awaiting change review label Jul 1, 2026

rok mentioned this pull request Jul 1, 2026

[C++][Python] Add "hypot" compute kernel #50197

Closed

shrivasshankar deleted the feature/add-hypot-kernel branch July 1, 2026 01:25

Uh oh!

Conversation

shrivasshankar commented Jun 16, 2026 • edited by kou Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions Bot commented Jun 16, 2026

Uh oh!

shrivasshankar commented Jun 21, 2026

Uh oh!

rok commented Jun 24, 2026

Uh oh!

Uh oh!

shrivasshankar commented Jun 28, 2026

Uh oh!

rok left a comment

Choose a reason for hiding this comment

Uh oh!

rok commented Jun 29, 2026

Uh oh!

shrivasshankar commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rok left a comment

Choose a reason for hiding this comment

Uh oh!

shrivasshankar commented Jun 29, 2026

Uh oh!

shrivasshankar commented Jun 30, 2026

Uh oh!

rok commented Jun 30, 2026

Uh oh!

Uh oh!

Uh oh!

rok commented Jun 30, 2026

Uh oh!

rok left a comment

Choose a reason for hiding this comment

Uh oh!

shrivasshankar commented Jul 1, 2026

Uh oh!

Uh oh!

Uh oh!

rok commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shrivasshankar commented Jun 16, 2026 •

edited by kou

Loading

shrivasshankar commented Jun 29, 2026 •

edited

Loading

rok commented Jul 1, 2026 •

edited

Loading