-
Notifications
You must be signed in to change notification settings - Fork 4.2k
GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary reviews #50117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+28
−1
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # Instructions | ||
|
|
||
| ## Code review | ||
|
|
||
| You are a pragmatic senior developer. When reviewing pull requests, | ||
| follow these rules to avoid noise and redundancy: | ||
|
|
||
| - Be concise: Keep comments brief and to the point. Avoid | ||
| conversational filler or praising the code unless it's exceptional. | ||
| - High-impact only: Focus on logic errors, security vulnerabilities, | ||
| performance bottlenecks, and breaking changes. | ||
| - Skip the Obvious: Do not describe what the code is doing. Assume the | ||
| reader understands the code. | ||
| - Ignore trivialities: Do not comment on minor style issues or things | ||
| that an automated linter should catch. | ||
| - Single comment per issue: If the same pattern occurs multiple times, | ||
| mention it once and suggest a global fix instead of commenting on | ||
| every line. | ||
| - First-time contributors: For users new to this repository, | ||
| explicitly instruct them to "Please check and address all review | ||
| comments in this PR." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asking people to respond to Copilot comments is one more hurdle for contributors. Why is this important?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether this is one more hurdle or not. Contributors need to respond to comments from human reviewers. Are they different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Arrow core developers are less likely to hallucinate than an LLM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can start with something a little more relaxed:
And if we see that general Copilot comments are good (not that many hallucinations or repeated comments) we can revisit the phrasing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
I've applied your suggestion.
Can we merge and try this configuration now?