Skip to content

GH-50054: [C++][IPC] Validate indices buffer size in ReadSparseCOOIndex #50055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rok merged 3 commits into from
Jun 30, 2026
Merged

GH-50054: [C++][IPC] Validate indices buffer size in ReadSparseCOOIndex #50055

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c22b9e3
GH-50054: [C++][IPC] Validate indices buffer size in ReadSparseCOOIndex
metsw24-max May 27, 2026
e7ac2b2
Update cpp/src/arrow/ipc/reader.cc
rok Jun 30, 2026
c3c383f
Apply suggestion from @rok
rok Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cpp/src/arrow/ipc/reader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2293,6 +2293,14 @@ Result<std::shared_ptr<SparseIndex>> ReadSparseCOOIndex(
file->ReadAt(indices_buffer->offset(), indices_buffer->length(),
/*allow_short_read=*/false));
std::vector<int64_t> indices_shape({non_zero_length, ndim});
int64_t indices_minimum_bytes;
if (MultiplyWithOverflow(non_zero_length, ndim,
&indices_minimum_bytes) ||
MultiplyWithOverflow(indices_minimum_bytes, indices_elsize,
&indices_minimum_bytes) ||
Comment thread
rok marked this conversation as resolved.
Outdated
indices_minimum_bytes > indices_buffer->length()) {
return Status::Invalid("shape is inconsistent to the size of indices buffer");
}
auto* indices_strides = sparse_index->indicesStrides();
std::vector<int64_t> strides(2);
if (indices_strides && indices_strides->size() > 0) {
Expand Down
Loading