Skip to content

GH-49728: [CI] Set persist-credentials: false in checkout actions#49734

Merged
thisisnic merged 2 commits into
apache:mainfrom
thisisnic:GH-49728-persist-credentials
Apr 14, 2026
Merged

GH-49728: [CI] Set persist-credentials: false in checkout actions#49734
thisisnic merged 2 commits into
apache:mainfrom
thisisnic:GH-49728-persist-credentials

Conversation

@thisisnic

@thisisnic thisisnic commented Apr 14, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Some CI jobs didn't have persist-credential set to false, which presents potential risks

What changes are included in this PR?

Set persist-credentials to false

Are these changes tested?

Run CI jobs

Are there any user-facing changes?

No

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #49728 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions Bot added CI: Extra: C++ Run extra C++ CI CI: Extra: Package: Linux Run extra Linux Packages CI awaiting committer review Awaiting committer review labels Apr 14, 2026

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should add it here:

with:
fetch-depth: {{ fetch_depth }}

and potentially here too:
with:
path: crossbow

@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Apr 14, 2026
@github-actions github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 14, 2026
@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Apr 14, 2026
@thisisnic thisisnic merged commit 47053cc into apache:main Apr 14, 2026
96 of 111 checks passed
@thisisnic thisisnic removed the awaiting merge Awaiting merge label Apr 14, 2026
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 47053cc.

There was 1 benchmark result with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
…ns (apache#49734)

### Rationale for this change

Some CI jobs didn't have persist-credential set to false, which presents potential risks

### What changes are included in this PR?

Set persist-credentials to false

### Are these changes tested?

Run CI jobs

### Are there any user-facing changes?

No

* GitHub Issue: apache#49728

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: Extra: C++ Run extra C++ CI CI: Extra: Package: Linux Run extra Linux Packages CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants