Skip to content

GH-49632: [C++][R] Remove deprecated old MinGW CMake fixes for AWS #49633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Apr 2, 2026
Merged

GH-49632: [C++][R] Remove deprecated old MinGW CMake fixes for AWS #49633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 0 additions & 52 deletions cpp/cmake_modules/ThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3902,35 +3902,6 @@ function(build_awssdk)
string(REPLACE "-flto=auto" "" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
string(REPLACE "-ffat-lto-objects" "" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")

# For aws-c-io
if(MINGW AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "9")
# This is for RTools 40. We can remove this after we dropped
# support for R < 4.2. schannel.h in RTools 40 is old.

# For schannel.h
#
# See also:
# https://learn.microsoft.com/en-us/windows/win32/api/schannel/ns-schannel-schannel_cred
string(APPEND CMAKE_C_FLAGS " -DSP_PROT_TLS1_0_SERVER=0x00000040")
string(APPEND CMAKE_C_FLAGS " -DSP_PROT_TLS1_0_CLIENT=0x00000080")
string(APPEND CMAKE_C_FLAGS " -DSP_PROT_TLS1_1_SERVER=0x00000100")
string(APPEND CMAKE_C_FLAGS " -DSP_PROT_TLS1_1_CLIENT=0x00000200")
string(APPEND CMAKE_C_FLAGS " -DSP_PROT_TLS1_2_SERVER=0x00000400")
string(APPEND CMAKE_C_FLAGS " -DSP_PROT_TLS1_2_CLIENT=0x00000800")
string(APPEND CMAKE_C_FLAGS " -DSP_PROT_TLS1_3_SERVER=0x00001000")
string(APPEND CMAKE_C_FLAGS " -DSP_PROT_TLS1_3_CLIENT=0x00002000")
string(APPEND CMAKE_C_FLAGS " -DSCH_USE_STRONG_CRYPTO=0x00400000")

# For sspi.h
#
# See also:
# https://learn.microsoft.com/en-us/windows/win32/api/sspi/ne-sspi-sec_application_protocol_negotiation_ext
string(APPEND CMAKE_C_FLAGS " -DSecApplicationProtocolNegotiationExt_ALPN=2")
# See also:
# https://learn.microsoft.com/en-us/windows/win32/api/sspi/ns-sspi-secbuffer
string(APPEND CMAKE_C_FLAGS " -DSECBUFFER_ALERT=17")
endif()

# For aws-sdk-cpp
#
# We need to use CACHE variables because aws-sdk-cpp < 1.12.0 uses
Expand Down Expand Up @@ -3970,29 +3941,6 @@ function(build_awssdk)
CACHE STRING "" FORCE)
endif()
endif()
if(MINGW AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "9")
# This is for RTools 40. We can remove this after we dropped
# support for R < 4.2. schannel.h in RTools 40 is old.

# For winhttp.h
#
# See also:
# https://learn.microsoft.com/en-us/windows/win32/winhttp/error-messages
string(APPEND CMAKE_CXX_FLAGS " -DERROR_WINHTTP_UNHANDLED_SCRIPT_TYPE=12176")
string(APPEND CMAKE_CXX_FLAGS " -DERROR_WINHTTP_SCRIPT_EXECUTION_ERROR=12177")
# See also:
# https://learn.microsoft.com/en-us/windows/win32/api/winhttp/ns-winhttp-winhttp_async_result
string(APPEND CMAKE_CXX_FLAGS " -DAPI_GET_PROXY_FOR_URL=6")
# See also:
# https://learn.microsoft.com/en-us/windows/win32/api/winhttp/nc-winhttp-winhttp_status_callback
string(APPEND CMAKE_CXX_FLAGS " -DWINHTTP_CALLBACK_STATUS_CLOSE_COMPLETE=0x02000000")
string(APPEND CMAKE_CXX_FLAGS
" -DWINHTTP_CALLBACK_STATUS_SHUTDOWN_COMPLETE=0x04000000")
# See also:
# https://learn.microsoft.com/en-us/windows/win32/winhttp/option-flags
string(APPEND CMAKE_CXX_FLAGS " -DWINHTTP_FLAG_SECURE_PROTOCOL_TLS1_2=0x00000800")
string(APPEND CMAKE_CXX_FLAGS " -DWINHTTP_NO_CLIENT_CERT_CONTEXT=0")
endif()

set(AWSSDK_LINK_LIBRARIES)
foreach(AWSSDK_PRODUCT ${AWSSDK_PRODUCTS})
Expand Down
Loading