Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH-49538: [C++][FlightRPC][ODBC] Use static linkage in Windows FlightSQL ODBC driver #49585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
GH-49538: [C++][FlightRPC][ODBC] Use static linkage in Windows FlightSQL ODBC driver #49585
Changes from all commits
bd4eb4b36d5d0979edd5bdbabf185e051365b17b16f6859cd844448828c1079207d9a23ca1934298afcd4f66324f96f04abf511a262c1e855249de0406d1e3e3f1a411248587943f587193817596478b82309b531898d6e5b479f3acb06e8fe092b012aa83327ea5b481b6b4c9ecc3fc009c48b94b4ba1a2eb2173be869738d0b18710ed574bc2cf6File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lidavidm @raulcd @kou do any of you have any thoughts on this workaround I came up with using Claude? I can dig in more if any of you want.
It makes sense that the duplicate symbol could show up twice with how the build is set up and I can see why this only shows up in Debug builds: https://github.com/abseil/abseil-cpp/blob/master/absl/synchronization/mutex.h#L1197.
The
/FORCE:MULTIPLEworkaround seems like a heavy fix.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happens despite linking everything statically? Ugh, I guess it is what it is. (Also: is it just me, or do the preprocessor condition and the comment there contradict each other? The symbol is only defined when not building DLL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gentle ping @lidavidm @raulcd @kou Do you think this PR can be merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I see the full command line when the link error happens?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.