-
Notifications
You must be signed in to change notification settings - Fork 4.2k
GH-32123: [R] Expose azure blob filesystem #49553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marberts
wants to merge
88
commits into
apache:main
Choose a base branch
from
marberts:32123-expose-azure-blob-filesystem
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 87 commits
Commits
Show all changes
88 commits
Select commit
Hold shift + click to select a range
e249867
Add AzureBlobFileSystem placeholder, verify devtools::document() beha…
Collinbrown95 a9f85c3
add simple test function to work through codegen.R
Collinbrown95 00dfa1c
temporarily "force" build DARROW_R_WITH_AZUREFS build flag.
Collinbrown95 cb77017
Added c++ stub
marberts 8b811aa
Updated codegen
marberts 0e9d2b9
Added a comment
marberts 1bc3e42
cleanup azurefs test function code
Collinbrown95 cb8ed62
document instructions to start local azurite container
Collinbrown95 0966367
add arrow_with_azure helper following convention for s3/gcp
Collinbrown95 e843a54
add ARROW_AZURE flag to nixlibs.R
Collinbrown95 a73ad16
debug first argument check
Collinbrown95 4b650d0
Renamed R6 class correctly
marberts 0329839
Added endpoint + key, token, and default authentication
marberts b1e5fec
Finished logical for AzureFileSystem to match pyarrow
marberts 765f89f
standardize on ARROW_R_WITH_AZURE instead of ARROW_R_WITH_AZUREFS
Collinbrown95 8c3efaf
standardize on ARROW_R_WITH_AZURE
Collinbrown95 868e653
Turn on ARROW_AZURE flag in nixlibs.R
Collinbrown95 8f8862c
drop temporary arrow env var hack
Collinbrown95 163a76a
temporary documentation of what I've tried so far
Collinbrown95 2b0e367
Add TODO note in configure script to remove hard-coded link flags
Collinbrown95 919edc3
initial filesystem tests
Collinbrown95 421ca19
uncomment line 256 of filesystem.cpp
Collinbrown95 b9e97a7
checkpoint: resolved segfault error
Collinbrown95 4e61485
skip test_filesystem tests that rely on being able to connect directl…
Collinbrown95 130cb3f
Add most test cases from test_filesystem and recreate a couple that w…
Collinbrown95 8b5bcbd
rename az_bucket to az_container
Collinbrown95 3c3e081
check that azurite is installed as precondition for test-azure.R script.
Collinbrown95 33e614f
add setup code to start azurite from the test-azure.R script, then ki…
Collinbrown95 f7615a7
run air formatter
Collinbrown95 8aeb29a
add documentation to az_container.
Collinbrown95 73e2355
docs: Updated documentation for AzureFileSystem and updated vignette …
marberts 9034ec7
Updated installation vignettes to include Azure
marberts 8bd4737
Updated install scripts
marberts e2cba0a
add tests for valid and invalid combinations of options to AzureFileS…
Collinbrown95 5260ba8
Ran pre-commit hooks
marberts 7d52cbc
Removed tmp.md
marberts 32f8422
wrap credential configuration methods with StopIfNotOk
Collinbrown95 f6107e2
move link flags to arrow_built_with ARROW_AZURE block in configure sc…
Collinbrown95 9f246a2
fix error message to check in test for empty call to AzureFileSystem$…
Collinbrown95 d1627e3
Updated docs to include libxml2
marberts 46fc6dc
add simple test function to work through codegen.R
Collinbrown95 0d790f6
cleanup azurefs test function code
Collinbrown95 09c8089
Updated filesystem.cpp
marberts 2ffa6ad
Updated build scripts
marberts fb58522
Update configure.win: fix typo
Collinbrown95 81d563b
Updated CI setup scripts for windows
marberts b3de919
Trying PKGBUILD and windows build script again
marberts fa17e21
Updated PKGBUILD
marberts b911bca
debug ci: add azure dependencies that CI tries to build from source.
Collinbrown95 3a1cc33
Removed tmp.md
marberts 5ae1105
add install script to build azure-sdk-for-cpp dependencies from source.
1630574
add simple test function to work through codegen.R
Collinbrown95 51593bc
temporarily "force" build DARROW_R_WITH_AZUREFS build flag.
Collinbrown95 2ad013c
Added c++ stub
marberts c8a73e5
cleanup azurefs test function code
Collinbrown95 2ee6eb6
document instructions to start local azurite container
Collinbrown95 a47bb9e
debug first argument check
Collinbrown95 add7652
Added endpoint + key, token, and default authentication
marberts 020fca2
Finished logical for AzureFileSystem to match pyarrow
marberts 156a945
standardize on ARROW_R_WITH_AZURE
Collinbrown95 96ac7e9
temporary documentation of what I've tried so far
Collinbrown95 ddf80e3
Add TODO note in configure script to remove hard-coded link flags
Collinbrown95 bb5d887
uncomment line 256 of filesystem.cpp
Collinbrown95 d3d9b9e
checkpoint: resolved segfault error
Collinbrown95 9068886
Add most test cases from test_filesystem and recreate a couple that w…
Collinbrown95 8a8267d
check that azurite is installed as precondition for test-azure.R script.
Collinbrown95 93e1cdf
Ran pre-commit hooks
marberts 6ef0963
Removed tmp.md
marberts f8e787d
wrap credential configuration methods with StopIfNotOk
Collinbrown95 a1d72ab
move link flags to arrow_built_with ARROW_AZURE block in configure sc…
Collinbrown95 82a5d37
add simple test function to work through codegen.R
Collinbrown95 246ff27
cleanup azurefs test function code
Collinbrown95 1bdf2ab
Trying PKGBUILD and windows build script again
marberts 7148238
Updated PKGBUILD
marberts d1c73bb
debug ci: add azure dependencies that CI tries to build from source.
Collinbrown95 8839eb2
Removed tmp.md
marberts 9639d0f
Removed windows build and added macos
marberts cb1cb9f
azure off for windows ci
marberts b367140
Disable azure in configure.win
marberts c4db209
Add placeholder comment to flag present issues with MinGW and the Azu…
Collinbrown95 ce2e058
remove debugging script to install azure sdk from source
Collinbrown95 1279b02
Updated vignettes to reflect Azure off on Windows
marberts c728602
Update github.packages.yml
marberts 4c370ca
Fixing lint in filesystem.cpp
marberts df23828
Fixed warning in cpp code
marberts 739e455
Added build info for azure to tasks for mac + a couple code comments
marberts 004e725
Fixed line endings on github.packages yaml
marberts 1ea9150
libxml2 warning in with_cloud_support() is now conditional on azure b…
marberts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are holdovers from when you were trying these on Windows, yeah?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I left these commented out in case progress gets made in the future around the incompatibility with mingw and the azure SDK stuff. Happy to either remove them or make it clearer in the comments.