GH-49531: [CI][Packaging][Python] Ignore cleanup errors trying to remove loaded DLLs from temp dir#49532
Conversation
…to remove loaded DLLs from temp dir
|
@github-actions crossbow submit wheel-windows-cp313-cp313-amd64 |
|
|
|
Revision: 2b141d8 Submitted crossbow builds: ursacomputing/crossbow @ actions-0ac593c079
|
|
@github-actions crossbow submit wheel-windows-* |
|
Revision: 2b141d8 Submitted crossbow builds: ursacomputing/crossbow @ actions-2522b5d0c0
|
|
cc @rok |
rok
left a comment
rok
left a comment
There was a problem hiding this comment.
Oh dear. Should we unlink (del pyarrow?) in add_docstrings_to_stubs instead?
This seems cleaner though.
github-actions
Bot
added
awaiting merge
I think the problem is when we load the DLL on Windows there seems to have problems to remove the file. From what I was reading even trying to manually unload the DLL might not work reliably. As this is only happening on limited scenarios (CI when building wheels for Windows) and we don't expect users to run this locally as often, I think this is fine. |
|
Yeah, agreed. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 7ec459a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…to remove loaded DLLs from temp dir (apache#49532) ### Rationale for this change Updating docstrings is failing on Windows trying to remove arrow.dll from tempdir because its still loaded in memory. ### What changes are included in this PR? Added `ignore_cleanup_errors=True` ### Are these changes tested? Yes via archery ### Are there any user-facing changes? No * GitHub Issue: apache#49531 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
…to remove loaded DLLs from temp dir (apache#49532) ### Rationale for this change Updating docstrings is failing on Windows trying to remove arrow.dll from tempdir because its still loaded in memory. ### What changes are included in this PR? Added `ignore_cleanup_errors=True` ### Are these changes tested? Yes via archery ### Are there any user-facing changes? No * GitHub Issue: apache#49531 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
2 participants
Rationale for this change
Updating docstrings is failing on Windows trying to remove arrow.dll from tempdir because its still loaded in memory.
What changes are included in this PR?
Added
ignore_cleanup_errors=TrueAre these changes tested?
Yes via archery
Are there any user-facing changes?
No