Skip to content

GH-49509: [Docs][Python][C++] Minimize warnings and docutils errors for Sphinx build html#49510

Merged
rok merged 5 commits into
apache:mainfrom
tadeja:sphinx-build-html-errors
Mar 17, 2026
Merged

GH-49509: [Docs][Python][C++] Minimize warnings and docutils errors for Sphinx build html#49510
rok merged 5 commits into
apache:mainfrom
tadeja:sphinx-build-html-errors

Conversation

@tadeja

@tadeja tadeja commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator

Rationale for this change

Closes #49509

What changes are included in this PR?

Docs formatting/typos corrected.

Are these changes tested?

Yes, on fork branch.

Are there any user-facing changes?

No, just corrected formatting/typos in docs.

@tadeja

tadeja commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator Author

Reposting from the issue:

Examples of CI logs
AMD64 Conda Python 3.11 Sphinx & Numpydoc
AMD64 Debian 12 Complete Documentation
AMD64 Conda Python 3.12 Sphinx Documentation

/opt/conda/envs/arrow/lib/python3.12/site-packages/numpydoc/docscrape.py:203: UserWarning: potentially wrong underline length... 
Example 
-------- in 
...
/opt/conda/envs/arrow/lib/python3.12/site-packages/pyarrow/compute.py:docstring of pyarrow.compute.atanh_checked:4: ERROR: Undefined substitution referenced: "x". [docutils]
docstring of pyarrow.lib.BaseListArray.flatten:44: ERROR: Unexpected indentation. [docutils]
docstring of pyarrow.lib.BaseListArray.flatten:47: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils]
...
/build/python/docs/source/cpp/api/cuda.rst:73: WARNING: Error when parsing function declaration
...
WARNING: unknown role name: python:mod
/build/python/docs/source/cpp/env_vars.rst:96: ERROR: Unknown interpreted text role "python:mod". [docutils]
...
/build/python/docs/source/format/Security.rst:62: WARNING: undefined label: '_format_columnar' [ref.ref]
/build/python/docs/source/format/Security.rst:173: WARNING: undefined label: '_ipc-message-format' [ref.ref]
...

@tadeja

tadeja commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator Author

Most of the errors show up as malformed doc pages and correcting these improves doc page readability;

/opt/conda/envs/arrow/lib/python3.12/site-packages/pyarrow/parquet/core.py:docstring of pyarrow.parquet.core.write_table:195: ERROR: Unexpected indentation. [docutils]
/opt/conda/envs/arrow/lib/python3.12/site-packages/pyarrow/parquet/core.py:docstring of pyarrow.parquet.core.write_table:196: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
..

https://arrow.apache.org/docs/dev/python/generated/pyarrow.parquet.write_table.html
Unintentional text boxes within malformed listings of the physical types: - int32:, - fixed_len_byte_array: , and - binary:
Screenshot 2026-03-13 at 17 35 38

  • min_chunk_size: and -max_chunk_size:
Screenshot 2026-03-13 at 17 43 10

@tadeja

tadeja commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator Author

@tadeja

tadeja commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator Author

Broken bool_ https://arrow.apache.org/docs/dev/python/generated/pyarrow.Bool8Array.html#pyarrow.Bool8Array.from_numpy
Screenshot 2026-03-13 at 18 21 12
and malformed flatten code example

https://arrow.apache.org/docs/dev/python/generated/pyarrow.ListArray.html#pyarrow.ListArray.flatten
Screenshot 2026-03-13 at 18 25 00

docstring of pyarrow.lib.Bool8Array.from_numpy:2: ERROR: Unknown target name: "bool". [docutils]
...
docstring of pyarrow.lib.BaseListArray.flatten:44: ERROR: Unexpected indentation. [docutils]
docstring of pyarrow.lib.BaseListArray.flatten:47: WARNING: Definition list ends without a blank line; unexpected unindent. [docutils]
docstring of pyarrow.lib.BaseListArray.flatten:49: ERROR: Unexpected indentation. [docutils]
docstring of pyarrow.lib.BaseListArray.flatten:51: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
docstring of pyarrow.lib.BaseListArray.flatten:53: ERROR: Unexpected indentation. [docutils]
docstring of pyarrow.lib.BaseListArray.flatten:55: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
docstring of pyarrow.lib.BaseListArray.flatten:56: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
...
...

@rok rok removed request for assignUser, jonkeane and kou March 16, 2026 15:01
@kou

kou commented Mar 16, 2026

Copy link
Copy Markdown
Member

@github-actions crossbow submit preview-docs

@github-actions

Copy link
Copy Markdown

Revision: 79c71f0

Submitted crossbow builds: ursacomputing/crossbow @ actions-0a3dab5269

Task Status
preview-docs GitHub Actions

@tadeja

tadeja commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator Author

@rok could you do a pass?

Comment thread python/pyarrow/array.pxi
@github-actions github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Mar 17, 2026
Comment thread python/pyarrow/array.pxi
Comment thread python/pyarrow/table.pxi
Comment thread python/pyarrow/_azurefs.pyx
Comment thread python/pyarrow/parquet/core.py
Comment thread python/pyarrow/_compute.pyx
Comment thread docs/source/format/Security.rst
Comment thread docs/source/format/Security.rst
Comment thread docs/source/cpp/env_vars.rst
Comment thread docs/source/format/CanonicalExtensions.rst Outdated
Comment thread docs/source/implementations.rst
Comment thread cpp/apidoc/Doxyfile
__declspec(x)= \
ARROW_ACERO_EXPORT= \
ARROW_ARG_UNUSED(x)=x \
ARROW_CUDA_EXPORT= \

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the commit adding new ARROW_CUDA_EXPORT and adding it now to Doxyfile resolves these:

/build/python/docs/source/cpp/api/cuda.rst:73: WARNING: Error when parsing function declaration.
If the function has no return type:
  Error in declarator or parameters-and-qualifiers
Error: at 18]
    ARROW_CUDA_EXPORT Result< std::shared_ptr< CudaBuffer > > SerializeRecordBatch (const RecordBatch &batch, CudaContext *ctx)
    ------------------^
...

@tadeja

tadeja commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator Author

I've excluded some unnecessarily complex fixes for now( like this CI change ), so with current fixes we get:
Down from current on main: build succeeded, 129 warnings.
to nicer: build succeeded, 45 warnings.

@rok

rok commented Mar 17, 2026

Copy link
Copy Markdown
Member

@raulcd quick look perhaps? I'll merge tonight if CI passes.

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am no expert on sphinx, doxygen or restructured text but all those changes look reasonable to me.

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Mar 17, 2026
@rok rok merged commit 6dfef94 into apache:main Mar 17, 2026
61 of 62 checks passed
@rok rok removed the awaiting merge Awaiting merge label Mar 17, 2026
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6dfef94.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Apr 6, 2026
…rors for Sphinx build html (apache#49510)

### Rationale for this change
Closes apache#49509

### What changes are included in this PR?
Docs formatting/typos corrected.

### Are these changes tested?
Yes, on fork branch.

### Are there any user-facing changes?
No, just corrected formatting/typos in docs.
* GitHub Issue: apache#49509

Authored-by: Tadeja Kadunc <tadeja.kadunc@gmail.com>
Signed-off-by: Rok Mihevc <rok@mihevc.org>
@tadeja tadeja deleted the sphinx-build-html-errors branch April 9, 2026 11:58
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
…rors for Sphinx build html (apache#49510)

### Rationale for this change
Closes apache#49509

### What changes are included in this PR?
Docs formatting/typos corrected.

### Are these changes tested?
Yes, on fork branch.

### Are there any user-facing changes?
No, just corrected formatting/typos in docs.
* GitHub Issue: apache#49509

Authored-by: Tadeja Kadunc <tadeja.kadunc@gmail.com>
Signed-off-by: Rok Mihevc <rok@mihevc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs][Python][C++] Minimize warnings and docutils errors for Sphinx build html where possible

4 participants