Skip to content

GH-49434: [C++][CI] Add golden integration files to IPC file fuzz corpus#49440

Merged
pitrou merged 1 commit into
apache:mainfrom
pitrou:gh49434-golden-ipc-file
Mar 4, 2026
Merged

GH-49434: [C++][CI] Add golden integration files to IPC file fuzz corpus#49440
pitrou merged 1 commit into
apache:mainfrom
pitrou:gh49434-golden-ipc-file

Conversation

@pitrou

@pitrou pitrou commented Mar 3, 2026

Copy link
Copy Markdown
Member

Rationale for this change

For the IPC stream fuzzer, we are adding the golden integration files to the seed corpus, but we are currently not doing the same thing for the file fuzzer.

What changes are included in this PR?

  1. Add golden IPC integration files to the IPC file fuzzer seed corpus
  2. Minor cosmetic changes to the C++ test script, to make the output slightly less bulky (no functional difference)

Are these changes tested?

Yes, by existing CI tests.

Are there any user-facing changes?

No.

@pitrou pitrou marked this pull request as ready for review March 3, 2026 15:59
@pitrou

pitrou commented Mar 3, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit -g cpp

@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown

Revision: b7752de

Submitted crossbow builds: ursacomputing/crossbow @ actions-d059852edf

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-debian-13-cpp-amd64 GitHub Actions
test-debian-13-cpp-i386 GitHub Actions
test-debian-experimental-cpp-gcc-15 GitHub Actions
test-fedora-42-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@pitrou pitrou force-pushed the gh49434-golden-ipc-file branch from b7752de to bbfbf5c Compare March 3, 2026 16:28
@pitrou pitrou requested a review from wgtmac as a code owner March 3, 2026 16:28
@github-actions github-actions Bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Mar 4, 2026
@pitrou

pitrou commented Mar 4, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit wheel-macos-monterey-cp313-cp313-arm64

@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown

Revision: ce494fc

Submitted crossbow builds: ursacomputing/crossbow @ actions-e6089ea28d

Task Status
wheel-macos-monterey-cp313-cp313-arm64 GitHub Actions

@pitrou

pitrou commented Mar 4, 2026

Copy link
Copy Markdown
Member Author

This PR fixes the macOS wheel build issues @raulcd

@pitrou pitrou merged commit 65993cd into apache:main Mar 4, 2026
46 of 51 checks passed
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Mar 4, 2026
@raulcd

raulcd commented Mar 4, 2026

Copy link
Copy Markdown
Member

This PR fixes the macOS wheel build issues

Thanks @pitrou !

@pitrou pitrou deleted the gh49434-golden-ipc-file branch March 4, 2026 09:38
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 65993cd.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Apr 6, 2026
…zz corpus (apache#49440)

### Rationale for this change

For the IPC stream fuzzer, we are adding the golden integration files to the seed corpus, but we are currently not doing the same thing for the file fuzzer.

### What changes are included in this PR?

1. Add golden IPC integration files to the IPC file fuzzer seed corpus
2. Minor cosmetic changes to the C++ test script, to make the output slightly less bulky (no functional difference)

### Are these changes tested?

Yes, by existing CI tests.

### Are there any user-facing changes?

No.

* GitHub Issue: apache#49434

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
…zz corpus (apache#49440)

### Rationale for this change

For the IPC stream fuzzer, we are adding the golden integration files to the seed corpus, but we are currently not doing the same thing for the file fuzzer.

### What changes are included in this PR?

1. Add golden IPC integration files to the IPC file fuzzer seed corpus
2. Minor cosmetic changes to the C++ test script, to make the output slightly less bulky (no functional difference)

### Are these changes tested?

Yes, by existing CI tests.

### Are there any user-facing changes?

No.

* GitHub Issue: apache#49434

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants