-
Notifications
You must be signed in to change notification settings - Fork 4.2k
GH-37958: [MATLAB] Centralize Command Window hyperlink formatting #49414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kriyanshii
wants to merge
6
commits into
apache:main
Choose a base branch
from
kriyanshii:utility-for-hyperlinking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b41a4d7
GH-37958: [MATLAB] Centralize Command Window hyperlink formatting
kriyanshii b9acf7a
review change: removed unncessary comment
kriyanshii be848d4
Fix display tests by using makeLinkString for class names
kriyanshii d42162f
Merge branch 'apache:main' into utility-for-hyperlinking
kriyanshii c76fd11
[MATLAB] Improve Arrow display headers with hyperlinkable type names
kriyanshii 3e9c3da
[MATLAB] Add hyperlinkable type names and shared display helpers for …
kriyanshii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
matlab/src/matlab/+arrow/+internal/+display/makeLinkString.m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| %MAKELINKSTRING Creates a hyperlink string if possible. | ||
|
|
||
| % Licensed to the Apache Software Foundation (ASF) under one or more | ||
| % contributor license agreements. See the NOTICE file distributed with | ||
| % this work for additional information regarding copyright ownership. | ||
| % The ASF licenses this file to you under the Apache License, Version | ||
| % 2.0 (the "License"); you may not use this file except in compliance | ||
| % with the License. You may obtain a copy of the License at | ||
| % | ||
| % http://www.apache.org/licenses/LICENSE-2.0 | ||
| % | ||
| % Unless required by applicable law or agreed to in writing, software | ||
| % distributed under the License is distributed on an "AS IS" BASIS, | ||
| % WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
| % implied. See the License for the specific language governing | ||
| % permissions and limitations under the License. | ||
|
|
||
| function link = makeLinkString(opts) | ||
| arguments | ||
| opts.HelpTarget(1, 1) string {mustBeNonzeroLengthText} | ||
| opts.Text(1, 1) string {mustBeNonzeroLengthText} | ||
| % When displaying heterogeneous arrays, only the name of the | ||
| % closest shared ancestor class is displayed in bold. All other | ||
| % class names are not bolded. | ||
| opts.BoldFont(1, 1) logical = false | ||
| end | ||
|
|
||
| if usejava("desktop") | ||
| if opts.BoldFont | ||
| link = compose("<a href=""matlab:helpPopup('%s')""" + ... | ||
| " style=""font-weight:bold"">%s</a>", ... | ||
| opts.HelpTarget, opts.Text); | ||
| else | ||
| link = compose("<a href=""matlab:helpPopup('%s')"">%s</a>", ... | ||
| opts.HelpTarget, opts.Text); | ||
| end | ||
| else | ||
| link = opts.Text; | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.