Skip to content

GH-49263: [Python][CI] Install rust compiler for libcst only on Debian 32 bits #49265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raulcd merged 5 commits into from
Feb 17, 2026
Merged

GH-49263: [Python][CI] Install rust compiler for libcst only on Debian 32 bits #49265

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6847715
GH-49263: [Python][CI] Install rust compiler for libcst only on Debia…
raulcd Feb 12, 2026
05b3a6c
Add missing semicolon
raulcd Feb 12, 2026
c54511d
Install rust and cargo unconditionally of i386 for debian
raulcd Feb 17, 2026
96f84d9
oops, I should review the abcedary again
raulcd Feb 17, 2026
91568bc
Package name is rustc not rust
raulcd Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ci/docker/debian-13-cpp.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ RUN apt-get update -y -q && \
tzdata \
tzdata-legacy \
zlib1g-dev && \
if [ ${arch} = "i386" ]; then \

@raulcd raulcd Feb 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kou I decided to add this here instead of on the debian-python one because we do not install any debian packages there and we install everything on this base. Let me know if you would prefer us to have this dependency there instead I am 50-50 on where should this go.

@kou kou Feb 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with installing Rust here.

BTW, how about always installing Rust instead of checking ${arch} = "i386"?

diff --git a/ci/docker/debian-13-cpp.dockerfile b/ci/docker/debian-13-cpp.dockerfile
index fe947db025..928443ee64 100644
--- a/ci/docker/debian-13-cpp.dockerfile
+++ b/ci/docker/debian-13-cpp.dockerfile
@@ -42,6 +42,7 @@ RUN apt-get update -y -q && \
     apt-get update -y -q && \
     apt-get install -y -q --no-install-recommends \
         autoconf \
+        cargo \
         ccache \
         clang-${llvm} \
         cmake \
@@ -86,6 +87,7 @@ RUN apt-get update -y -q && \
         python3-venv \
         rapidjson-dev \
         rsync \
+        rust \
         tzdata \
         tzdata-legacy \
         zlib1g-dev && \

I know that we don't need Rust for the armd64 platform but no ${arch} check will simplify our Dockerfile.

apt-get install -y -q --no-install-recommends rustc cargo; \
fi && \
apt-get clean && \
rm -rf /var/lib/apt/lists/*

Expand Down
Loading