Skip to content

GH-49129: [R][Parquet] Guard Parquet dataset code with ARROW_R_WITH_PARQUET #49128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IsabelParedes wants to merge 5 commits into from
Closed

GH-49129: [R][Parquet] Guard Parquet dataset code with ARROW_R_WITH_PARQUET #49128

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
54669fc
[R] Guard Parquet dataset code with ARROW_R_WITH_PARQUET
IsabelParedes Feb 3, 2026
7adc2a0
Add test without parquet
IsabelParedes Feb 3, 2026
7717fb7
Replace env vars with flags
IsabelParedes Feb 3, 2026
3ffdc3c
Add more guards
IsabelParedes Feb 3, 2026
990e09b
Fix nested guards
IsabelParedes Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions dev/tasks/tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,6 +713,15 @@ tasks:
R_DUCKDB_DEV: TRUE
image: ubuntu-r-only-r

test-r-dataset-without-parquet:
ci: github
template: docker-tests/github.linux.yml
params:
env:
ARROW_DATASET: ON
ARROW_PARQUET: OFF
Comment thread
IsabelParedes marked this conversation as resolved.
Outdated
image: ubuntu-r-only-r

test-r-offline-maximal:
ci: github
template: r/github.linux.offline.build.yml
Expand Down
2 changes: 1 addition & 1 deletion r/src/arrowExports.cpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions r/src/dataset.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@
#include <arrow/table.h>
#include <arrow/util/checked_cast.h>
#include <arrow/util/iterator.h>

#if defined(ARROW_R_WITH_PARQUET)
#include <parquet/properties.h>
#endif

namespace ds = ::arrow::dataset;
namespace fs = ::arrow::fs;
Expand Down Expand Up @@ -223,6 +226,7 @@ std::shared_ptr<ds::FileWriteOptions> dataset___FileFormat__DefaultWriteOptions(
return fmt->DefaultWriteOptions();
}

#if defined(ARROW_R_WITH_PARQUET)
// [[dataset::export]]
std::shared_ptr<ds::ParquetFileFormat> dataset___ParquetFileFormat__Make(
const std::shared_ptr<ds::ParquetFragmentScanOptions>& options,
Expand All @@ -237,6 +241,7 @@ std::shared_ptr<ds::ParquetFileFormat> dataset___ParquetFileFormat__Make(

return fmt;
}
#endif

// [[dataset::export]]
std::string dataset___FileWriteOptions__type_name(
Expand Down Expand Up @@ -339,6 +344,7 @@ std::shared_ptr<ds::JsonFragmentScanOptions> dataset___JsonFragmentScanOptions__
return options;
}

#if defined(ARROW_R_WITH_PARQUET)
// [[dataset::export]]
std::shared_ptr<ds::ParquetFragmentScanOptions>
dataset___ParquetFragmentScanOptions__Make(bool use_buffered_stream, int64_t buffer_size,
Expand All @@ -362,6 +368,7 @@ dataset___ParquetFragmentScanOptions__Make(bool use_buffered_stream, int64_t buf
thrift_container_size_limit);
return options;
}
#endif

// DirectoryPartitioning, HivePartitioning

Expand Down
Loading