-
Notifications
You must be signed in to change notification settings - Fork 4.2k
GH-48817 [R][C++] Bump C++20 in R build infrastructure #48819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
1055162
c9b9544
c8e6f3d
57abbb9
a5f0273
6ef56a5
0a01031
60fb687
d138f62
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,8 +23,8 @@ but there are a few things to note. | |
|
|
||
| ### Compilers | ||
|
|
||
| As of version 10.0.0, arrow requires a C++17 compiler to build. | ||
| For `gcc`, this generally means version 7 or newer. Most contemporary Linux | ||
| As of version 22.0.0, arrow requires a C++20 compiler to build. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be 23.0.0?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was aiming for 23, but we might have missed the boat on that one. We might still need to backport this to the CRAN release, so I'm going to put that for now. Regardless, yeah it's over 22 not 22 and over. |
||
| For `gcc`, this generally means version 10 or newer. Most contemporary Linux | ||
| distributions have a new enough compiler; however, CentOS 7 is a notable | ||
| exception, as it ships with gcc 4.8. | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does R still support macOS < 11? It's end-of-life since 2022.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, I need to dig to see what the actual number is and update this comment / remove this code path if we don't need it.