GH-24157: [C++] Add tests for DayTimeIntervalBuilder - #48709
Merged
Conversation
|
|
HyukjinKwon
marked this pull request as draft
January 2, 2026 03:27
HyukjinKwon
marked this pull request as ready for review
January 2, 2026 03:32
EnricoMi
reviewed
Jan 6, 2026
github-actions
Bot
added
awaiting committer review
EnricoMi
approved these changes
Jan 7, 2026
Member
Author
|
@kou do you mind if I ask to take a quick look please? I thought this is pretty strait forward 🙇 . |
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
github-actions
Bot
added
awaiting merge
Member
Author
is from #48786 fwiw! |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ddab347. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Mottl
pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
) ### Rationale for this change The `DayTimeIntervalBuilder` class was marked as untested (ARROW-7938). This PR adds dedicated tests to verify the builder's functionality, similar to how `TestHalfFloatBuilder` tests `HalfFloatBuilder`. ### What changes are included in this PR? - Added `TestDayTimeIntervalBuilder` test class with three test cases: - `TestAppend`: Tests basic append operations including nulls and unsafe append - `TestBulkAppend`: Tests bulk append operations with various signatures - `TestConstructors`: Tests all constructor variations (default, with pool, with explicit type) - Removed the TODO comment from `builder_time.h` since the class is now tested ### Are these changes tested? Yes, the tests I mentioned are added. ### Are there any user-facing changes? No, test-only. * GitHub Issue: apache#24157 Lead-authored-by: Hyukjin Kwon <gurwls223@apache.org> Co-authored-by: Hyukjin Kwon <gurwls223@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
DayTimeIntervalBuilderclass was marked as untested (ARROW-7938). This PR adds dedicated tests to verify the builder's functionality, similar to howTestHalfFloatBuildertestsHalfFloatBuilder.What changes are included in this PR?
TestDayTimeIntervalBuildertest class with three test cases:TestAppend: Tests basic append operations including nulls and unsafe appendTestBulkAppend: Tests bulk append operations with various signaturesTestConstructors: Tests all constructor variations (default, with pool, with explicit type)builder_time.hsince the class is now testedAre these changes tested?
Yes, the tests I mentioned are added.
Are there any user-facing changes?
No, test-only.