GH-48566: [C++][CI] Fix compilation on Valgrind job#48567
Conversation
|
@github-actions crossbow submit -g cpp |
|
Revision: c992f2b Submitted crossbow builds: ursacomputing/crossbow @ actions-3e51cc5fd8 |
raulcd
left a comment
There was a problem hiding this comment.
LGTM, the failure on test-ubuntu-24.04-cpp-thread-sanitizer isn't related but I haven't seen it anywhere else yet and I just triggered the cpp jobs on a different PR where all are green. It hasn't failed on the nightlies yet. Maybe is related to a commit on main, my PR isn't rebased to latest. I'll keep an eye for further failures on the job.
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 016e3cf. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 56 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change A `#include` required on Valgrind (due to conditional compilation) was removed in PR apache#45462. ### Are these changes tested? Yes, by existing CI jobs. ### Are there any user-facing changes? No. * GitHub Issue: apache#48566 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Rationale for this change
A
#includerequired on Valgrind (due to conditional compilation) was removed in PR #45462.Are these changes tested?
Yes, by existing CI jobs.
Are there any user-facing changes?
No.