GH-40735: [Packaging][CentOS] Drop support for CentOS 7 - #48550
Conversation
f8dd8ea to
df7fbb2
Compare
df7fbb2 to
13dcda7
Compare
raulcd
left a comment
There was a problem hiding this comment.
LGTM, thanks for tackling the improvements on the spec.in files.
A comment, not strictly related to the packaging side, do we want to also remove:
Lines 450 to 468 in 8fcab2f
and
https://github.com/apache/arrow/blob/main/ci/docker/centos-7-cpp.dockerfile
The centos-cpp-static compose service doesn't seem to be used anywhere.
We can do it on a different PR
|
Can we also clean up these: Lines 225 to 232 in b355fc0 arrow/dev/tasks/r/github.packages.yml Lines 367 to 368 in b355fc0 |
|
Thanks for checking @raulcd. +1 to dropping. |
|
@github-actions crossbow submit -g r |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit -g r |
|
R's Linux binaries for OpenSSL 1.0 and 1.1 use If we need a discussion for the decision, can we focus on only CentOS 7 RPM packages in this PR? |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit r-binary-packages |
|
Revision: abc5595 Submitted crossbow builds: ursacomputing/crossbow @ actions-ad8c1ef017
|
I think so. There's #45449 for that. |
|
Thanks. I'll revert R related changes in this PR. Let's work on it as a separated task. |
|
Reverted. |
|
Sorry, I missed this on the I am merging and we can tackle this on the other issue mentioned. Thanks @kou for working on this |
This is the docker image that made the R jobs fail. It is used on the Open SSL 1.x jobs. It should be removed as part of: This PR removed the linux packaging part so far. If we think it's necessary we can re-open the issue (GH-40735) and close it only when the Open SSL one has also been merged. I don't think it is necessary because the original issue was about Packaging. |
|
ok, it seems between my comment and me checking the PR for that issue @thisisnic just merged it but we haven't removed the Dockerfile. I'll create a PR to remove the Dockerfile and fix the docker-compose.yml |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2e12201. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…#48550) ### Rationale for this change There is no sponsor to maintain EOL-ed CentOS 7. ### What changes are included in this PR? Remove CentOS 7 packages related configurations. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#40735 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Rationale for this change
There is no sponsor to maintain EOL-ed CentOS 7.
What changes are included in this PR?
Remove CentOS 7 packages related configurations.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.