Skip to content

GH-40735: [Packaging][CentOS] Drop support for CentOS 7 - #48550

Merged
raulcd merged 8 commits into
apache:mainfrom
kou:packaging-drop-centos-7
Dec 17, 2025
Merged

GH-40735: [Packaging][CentOS] Drop support for CentOS 7#48550
raulcd merged 8 commits into
apache:mainfrom
kou:packaging-drop-centos-7

Conversation

@kou

@kou kou commented Dec 16, 2025

Copy link
Copy Markdown
Member

Rationale for this change

There is no sponsor to maintain EOL-ed CentOS 7.

What changes are included in this PR?

Remove CentOS 7 packages related configurations.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou
kou force-pushed the packaging-drop-centos-7 branch from df7fbb2 to 13dcda7 Compare December 16, 2025 01:04
@pitrou pitrou added the CI: Extra: Package: Linux Run extra Linux Packages CI label Dec 16, 2025

@raulcd raulcd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for tackling the improvements on the spec.in files.
A comment, not strictly related to the packaging side, do we want to also remove:

arrow/compose.yaml

Lines 450 to 468 in 8fcab2f

centos-cpp-static:
image: ${REPO}:centos-7-cpp-static
build:
context: .
dockerfile: ci/docker/centos-7-cpp.dockerfile
cache_from:
- ${REPO}:centos-7-cpp-static
args:
cmake: ${CMAKE}
shm_size: *shm-size
volumes:
- .:/arrow:delegated
environment:
<<: [*common, *ccache, *sccache, *cpp]
ARROW_DEPENDENCY_SOURCE: BUNDLED
ARROW_HOME: /arrow
LIBARROW_MINIMAL: "false"
command: /bin/bash -c "
scl enable devtoolset-8 '/arrow/r/inst/build_arrow_static.sh'"

and
https://github.com/apache/arrow/blob/main/ci/docker/centos-7-cpp.dockerfile

The centos-cpp-static compose service doesn't seem to be used anywhere.
We can do it on a different PR

@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Dec 16, 2025
@raulcd

raulcd commented Dec 16, 2025

Copy link
Copy Markdown
Member

@ianmcook @amoeba just FYI, the plan is merging this before 23.0.0, tagging for visibility.

@jonkeane

Copy link
Copy Markdown
Member

Can we also clean up these:

arrow/r/configure

Lines 225 to 232 in b355fc0

else
# Rewrite prefix= in arrow.pc on CentOS 7.
sed \
-i.bak \
-e "s,prefix=/arrow/r/libarrow/dist,prefix=${LIB_DIR}/..,g" \
${LIB_DIR}/pkgconfig/*.pc
rm -f ${LIB_DIR}/pkgconfig/*.pc.bak
fi

container: "rstudio/r-base:4.2-centos7"
steps:

https://github.com/apache/arrow/blob/b355fc085f6e148bef719bb1edefa47d870dab8d/ci/docker/centos-7-cpp.dockerfile

@amoeba

amoeba commented Dec 16, 2025

Copy link
Copy Markdown
Member

Thanks for checking @raulcd. +1 to dropping.

@kou

kou commented Dec 16, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit -g r

@github-actions github-actions Bot added Component: R awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Dec 16, 2025
@github-actions

This comment was marked as outdated.

@kou
kou requested a review from thisisnic as a code owner December 17, 2025 00:30
@kou

kou commented Dec 17, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit -g r

@kou

kou commented Dec 17, 2025

Copy link
Copy Markdown
Member Author

R's Linux binaries for OpenSSL 1.0 and 1.1 use centos-cpp-static. Can we drop support for OpenSSL 1.0 and 1.1 for R too?

If we need a discussion for the decision, can we focus on only CentOS 7 RPM packages in this PR?

@github-actions

This comment was marked as outdated.

@kou

kou commented Dec 17, 2025

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit r-binary-packages

@github-actions

Copy link
Copy Markdown

Revision: abc5595

Submitted crossbow builds: ursacomputing/crossbow @ actions-ad8c1ef017

Task Status
r-binary-packages GitHub Actions

@amoeba

amoeba commented Dec 17, 2025

Copy link
Copy Markdown
Member

R's Linux binaries for OpenSSL 1.0 and 1.1 use centos-cpp-static. Can we drop support for OpenSSL 1.0 and 1.1 for R too?

If we need a discussion for the decision, can we focus on only CentOS 7 RPM packages in this PR?

I think so. There's #45449 for that.

@kou

kou commented Dec 17, 2025

Copy link
Copy Markdown
Member Author

Thanks. I'll revert R related changes in this PR. Let's work on it as a separated task.

@kou

kou commented Dec 17, 2025

Copy link
Copy Markdown
Member Author

Reverted.

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Dec 17, 2025
@raulcd

raulcd commented Dec 17, 2025

Copy link
Copy Markdown
Member

Sorry, I missed this on the r-binary-packages github yml:

          - extra-cmake-flags: >-
              -DCMAKE_INCLUDE_PATH=/usr/include/openssl11
              -DCMAKE_LIBRARY_PATH=/usr/lib64/openssl11
            openssl: "1.1"
            os: centos
          - openssl: "1.0"
            os: centos

I am merging and we can tackle this on the other issue mentioned. Thanks @kou for working on this

@raulcd
raulcd merged commit 2e12201 into apache:main Dec 17, 2025
30 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Dec 17, 2025
@kou
kou deleted the packaging-drop-centos-7 branch December 17, 2025 09:30
@pitrou

pitrou commented Dec 17, 2025

Copy link
Copy Markdown
Member

Should this file and the corresponding docker-compose definitions have been removed too? @raulcd @kou

@raulcd

raulcd commented Dec 17, 2025

Copy link
Copy Markdown
Member

Should this file and the corresponding docker-compose definitions have been removed too?

This is the docker image that made the R jobs fail. It is used on the Open SSL 1.x jobs. It should be removed as part of:

This PR removed the linux packaging part so far. If we think it's necessary we can re-open the issue (GH-40735) and close it only when the Open SSL one has also been merged. I don't think it is necessary because the original issue was about Packaging.

@raulcd

raulcd commented Dec 17, 2025

Copy link
Copy Markdown
Member

ok, it seems between my comment and me checking the PR for that issue @thisisnic just merged it but we haven't removed the Dockerfile. I'll create a PR to remove the Dockerfile and fix the docker-compose.yml

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2e12201.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
…#48550)

### Rationale for this change

There is no sponsor to maintain EOL-ed CentOS 7.  

### What changes are included in this PR?

Remove CentOS 7 packages related configurations.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: apache#40735

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants