GH-48160: [C++][Gandiva] Pass cpu attrs to LLVM #48161
Open
+46
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The CPU Attrs are not passed to the llvm layer, which means potential optimizations could be missed leading to inefficient code. This feature was lost as part of the refactoring in 83cba25
Fixes #48160
What changes are included in this PR?
Pass the cpu attrs to the llvm code generation, and a unit test.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.